Changeset 33473

Timestamp:

07/29/2015 03:26:20 AM (9 years ago)

Author:

markjaquith

Message:

Re-work user-profile.js so the password meter works in IE8 and password managers can fill multiple times.

props adamsilverstein
fixes #32886

File:

• trunk/src/wp-admin/js/user-profile.js (modified) (6 diffs)

trunk/src/wp-admin/js/user-profile.js

@@ -14 +14 @@
 
         $submitButtons,
-        $submitButton;
+        $submitButton,
+        currentPass;
 
     function generatePassword() {
         if ( typeof zxcvbn !== 'function' ) {
-           setTimeout( generatePassword, 50 );
+            setTimeout( generatePassword, 50 );
         } else {
-           $pass1.val( $pass1.data( 'pw' ) );
-           $pass1.trigger( 'propertychange' );
-           $pass1Wrap.addClass( 'show-password' );
+            $pass1.val( $pass1.data( 'pw' ) );
+            $pass1.trigger( 'pwupdate' );
+            $pass1Wrap.addClass( 'show-password' );
         }
     }
@@ -28 +29 @@
     function bindPass1() {
         var passStrength = $('#pass-strength-result')[0];
-        var currentPass = $pass1.val();
+
+        currentPass = $pass1.val();
 
         $pass1Wrap = $pass1.parent();
@@ -41 +43 @@
             .data( 'pw', $pass1.data( 'pw' ) )
             .val( $pass1.val() )
-            .on( 'input', function () {
-                $pass1.val( $pass1Text.val() ).trigger( 'propertychange' );
+            .on( 'input propertychange', function () {
+                if ( $pass1Text.val() === currentPass ) {
+                    return;
+                }
+                $pass2.val( $pass1Text.val() );
+                $pass1.val( $pass1Text.val() ).trigger( 'pwupdate' );
+                currentPass = $pass1Text.val();
             } );
 
@@ -51 +58 @@
         }
 
-        $pass1.on( 'input propertychange', function () {
+        $pass1.on( 'input propertychange pwupdate', function () {
             if ( $pass1.val() === currentPass ) {
                 return;
@@ -150 +157 @@
          *
          * This fixes the issue by copying any changes from the hidden
-         * pass2 field to the pass1 field.
+         * pass2 field to the pass1 field, then running check_pass_strength.
          */
         $pass2 = $('#pass2').on( 'input propertychange', function () {
             if ( $pass2.val().length > 0 ) {
                 $pass1.val( $pass2.val() );
-                $pass1.trigger( 'propertychange' );
+                $pass2.val('');
+                currentPass = '';
+                $pass1.trigger( 'pwupdate' );
             }
         } );
@@ -229 +238 @@
             select = $( '#display_name' );
 
-        $('#pass1').val('').on( 'input propertychange', check_pass_strength );
-        $('#pass2').val('').on( 'input propertychange', check_pass_strength );
+        $('#pass1').val('').on( 'input propertychange pwupdate', check_pass_strength );
         $('#pass-strength-result').show();
         $('.color-palette').click( function() {