Changeset 33476

Timestamp:

07/29/2015 06:21:52 AM (10 years ago)

Author:

pento

Message:

WPDB: When checking the encoding of strings against the database, make sure we're only relying on the return value of strings that were sent to the database. Also make sure that we're not trying to sanity check strings that've been marked as not needing sanity checking.

Merge of [33455] to the 4.2 branch.

See #32279.

File:

• branches/4.2/src/wp-includes/wp-db.php (modified) (5 diffs)

branches/4.2/src/wp-includes/wp-db.php

@@ -2082 +2082 @@
         $this->func_call = "\$db->get_var(\"$query\", $x, $y)";
 
-        if ( $this->check_safe_collation( $query ) ) {
+        if ( $this->check_current_query && $this->check_safe_collation( $query ) ) {
             $this->check_current_query = false;
         }
@@ -2115 +2115 @@
         $this->func_call = "\$db->get_row(\"$query\",$output,$y)";
 
-        if ( $this->check_safe_collation( $query ) ) {
+        if ( $this->check_current_query && $this->check_safe_collation( $query ) ) {
             $this->check_current_query = false;
         }
@@ -2156 +2156 @@
      */
     public function get_col( $query = null , $x = 0 ) {
-        if ( $this->check_safe_collation( $query ) ) {
+        if ( $this->check_current_query && $this->check_safe_collation( $query ) ) {
             $this->check_current_query = false;
         }
@@ -2188 +2188 @@
         $this->func_call = "\$db->get_results(\"$query\", $output)";
 
-        if ( $this->check_safe_collation( $query ) ) {
+        if ( $this->check_current_query && $this->check_safe_collation( $query ) ) {
             $this->check_current_query = false;
         }
@@ -2714 +2714 @@
 
             foreach ( array_keys( $data ) as $column ) {
-                $data[ $column ]['value'] = $row["x_$column"];
+                if ( isset( $row["x_$column"] ) ) {
+                    $data[ $column ]['value'] = $row["x_$column"];
+                }
             }
         }