Changeset 33488 for trunk/src/wp-includes/class-wp-customize-widgets.php

Timestamp:

07/29/2015 04:02:08 PM (9 years ago)

Author:

westonruter

Message:

Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown.

• Ensure that a Custom Menu widget selecting a newly-inserted menu gets updated to use the new menu ID upon Save & Publish.
• Dynamically update the visibility of the Custom Menu widget's "no menus" message when the number of menus changes between 0 and 1+.
• Send all dirty Customized settings in update-widget Ajax request and preview() them so that the widget update/form callbacks have access to any data dependencies in the current Customizer session (such as newly created unsaved menus).
• Update link in Custom Menu widget to point to Menus panel as opposed to Menus admin page, when in the Customizer.
• Fix an issue with extra space at top immediately after creating new menu.
• Fix doubled update-widget Ajax requests when changing select dropdown; prevent initial from being aborted.
• Add missing wp_get_nav_menus() hooks to preview Customizer updates/inserts for nav_menu settings; includes tests.
• Update wp_get_nav_menu_object() to allow a menu object to be passed in (and thus passed through).

Props westonruter, adamsilverstein.
Fixes #32814.

File:

• trunk/src/wp-includes/class-wp-customize-widgets.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-customize-widgets.php

@@ -1242 +1242 @@
         global $wp_registered_widget_updates, $wp_registered_widget_controls;
 
+        $setting_id = $this->get_setting_id( $widget_id );
+
+        /*
+         * Make sure that other setting changes have previewed since this widget
+         * may depend on them (e.g. Menus being present for Custom Menu widget).
+         */
+        if ( ! did_action( 'customize_preview_init' ) ) {
+            foreach ( $this->manager->settings() as $setting ) {
+                if ( $setting->id !== $setting_id ) {
+                    $setting->preview();
+                }
+            }
+        }
+
         $this->start_capturing_option_updates();
         $parsed_id   = $this->parse_widget_id( $widget_id );
@@ -1322 +1336 @@
          * instead of the default widget instance value (an empty array).
          */
-        $setting_id = $this->get_setting_id( $widget_id );
         $this->manager->set_post_value( $setting_id, $instance );