Changeset 33492 for trunk/src/wp-admin/includes/class-wp-upgrader-skins.php

Timestamp:

07/29/2015 06:35:40 PM (11 years ago)

Author:

ocean90

Message:

Themes: Remove legacy theme preview.

The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader-skins.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-upgrader-skins.php

@@ -651 +651 @@
         $template   = $theme_info->get_template();
 
-        $preview_link = add_query_arg( array(
-            'preview'    => 1,
-            'template'   => urlencode( $template ),
-            'stylesheet' => urlencode( $stylesheet ),
-        ), trailingslashit( home_url() ) );
-
         $activate_link = add_query_arg( array(
             'action'     => 'activate',
@@ -665 +659 @@
 
         $install_actions = array();
-        $install_actions['preview']  = '<a href="' . esc_url( $preview_link ) . '" class="hide-if-customize"><span aria-hidden="true">' . __( 'Preview' ) . '</span><span class="screen-reader-text">' . sprintf( __( 'Preview &#8220;%s&#8221;' ), $name ) . '</span></a>';
+
         if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
             $install_actions['preview'] .= '<a href="' . wp_customize_url( $stylesheet ) . '" class="hide-if-no-customize load-customize"><span aria-hidden="true">' . __( 'Live Preview' ) . '</span><span class="screen-reader-text">' . sprintf( __( 'Live Preview &#8220;%s&#8221;' ), $name ) . '</span></a>';
@@ -733 +727 @@
             $template   = $theme_info->get_template();
 
-            $preview_link = add_query_arg( array(
-                'preview'    => 1,
-                'template'   => urlencode( $template ),
-                'stylesheet' => urlencode( $stylesheet ),
-            ), trailingslashit( home_url() ) );
-
             $activate_link = add_query_arg( array(
                 'action'     => 'activate',
@@ -751 +739 @@
                 }
             } elseif ( current_user_can( 'switch_themes' ) ) {
-                $update_actions['preview']  = '<a href="' . esc_url( $preview_link ) . '" class="hide-if-customize"><span aria-hidden="true">' . __( 'Preview' ) . '</span><span class="screen-reader-text">' . sprintf( __( 'Preview &#8220;%s&#8221;' ), $name ) . '</span></a>';
                 if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
                     $update_actions['preview'] .= '<a href="' . wp_customize_url( $stylesheet ) . '" class="hide-if-no-customize load-customize"><span aria-hidden="true">' . __( 'Live Preview' ) . '</span><span class="screen-reader-text">' . sprintf( __( 'Live Preview &#8220;%s&#8221;' ), $name ) . '</span></a>';