Changeset 33502

Timestamp:

07/29/2015 09:29:54 PM (10 years ago)

Author:

ocean90

Message:

Nav menus: Make the selector for the edit menu item link more specific. Prevents clashing with other elements which have the same class.

fixes #33129.

File:

• trunk/src/wp-admin/js/nav-menu.js (modified) (3 diffs)

trunk/src/wp-admin/js/nav-menu.js

@@ -391 +391 @@
             // Refresh the accessibility when the user comes close to the item in any way
             menu.on( 'mouseenter.refreshAccessibility focus.refreshAccessibility touchstart.refreshAccessibility' , '.menu-item' , function(){
-                api.refreshAdvancedAccessibilityOfItem( $( this ).find( '.item-edit' ) );
+                api.refreshAdvancedAccessibilityOfItem( $( this ).find( 'a.item-edit' ) );
             } );
 
             // We have to update on click as well because we might hover first, change the item, and then click.
-            menu.on( 'click', '.item-edit', function() {
+            menu.on( 'click', 'a.item-edit', function() {
                 api.refreshAdvancedAccessibilityOfItem( $( this ) );
             } );
@@ -512 +512 @@
 
             // Mark all menu items as unprocessed
-            $( '.item-edit' ).data( 'needs_accessibility_refresh', true );
+            $( 'a.item-edit' ).data( 'needs_accessibility_refresh', true );
 
             // All open items have to be refreshed or they will show no links
-            $( '.menu-item-edit-active .item-edit' ).each( function() {
+            $( '.menu-item-edit-active a.item-edit' ).each( function() {
                 api.refreshAdvancedAccessibilityOfItem( this );
             } );
@@ -521 +521 @@
 
         refreshKeyboardAccessibility : function() {
-            $( '.item-edit' ).off( 'focus' ).on( 'focus', function(){
+            $( 'a.item-edit' ).off( 'focus' ).on( 'focus', function(){
                 $(this).off( 'keydown' ).on( 'keydown', function(e){