Changeset 33596

Timestamp:

08/08/2015 09:36:55 AM (11 years ago)

Author:

ocean90

Message:

Customizer: Restore Shift + Clicking on widgets to open the widgets panel.

Includes an alternative for jQuery UI's :focusable selector because it has an ancestor visibility requirement, see ​https://github.com/jquery/jquery-ui/pull/1583.

props westonruter.
fixes #33258.

Location:

trunk/src/wp-admin/js

Files:

• customize-controls.js (modified) (1 diff)
• customize-widgets.js (modified) (1 diff)

trunk/src/wp-admin/js/customize-controls.js

@@ -74 +74 @@
                                 focusContainer = construct.container;
                         }
-                        focusContainer.find( ':focusable:first' ).focus();
-                        focusContainer[0].scrollIntoView( true );
+
+                        // Note that we can't use :focusable due to a jQuery UI issue. See: https://github.com/jquery/jquery-ui/pull/1583
+                        focusContainer.find( 'input, select, textarea, button, object, a[href], [tabindex]' ).filter( ':visible' ).first().focus();
                 };
                 if ( params.completeCallback ) {

trunk/src/wp-admin/js/customize-widgets.js

@@ -1271 +1271 @@
                         if ( expanded ) {
 
-                                if ( 'undefined' != typeof api.section( self.section ) && ! api.section( self.section ).expanded() ) {
+                                if ( self.section() && api.section( self.section() ) ) {
                                         self.expandControlSection();
                                 }