Changeset 33600

Timestamp:

08/09/2015 08:48:02 PM (11 years ago)

Author:

ocean90

Message:

Shortcodes: Trim whitespace after sanitizing the shortcode output.

props Ankit K Gupta, obenland, miqrogroove.
fixes #33259.

Location:

trunk

Files:

• src/wp-includes/shortcodes.php (modified) (1 diff)
• tests/phpunit/tests/shortcode.php (modified) (1 diff)

trunk/src/wp-includes/shortcodes.php

@@ -400 +400 @@
                                         // Sanitize the shortcode output using KSES.
                                         $new_attr = wp_kses_one_attr( $new_attr, $elname );
-                                        if ( '' !== $new_attr ) {
+                                        if ( '' !== trim( $new_attr ) ) {
                                                 // The shortcode is safe to use now.
                                                 $attr = $new_attr;

trunk/tests/phpunit/tests/shortcode.php

@@ -420 +420 @@
                         ),
                         array(
+                                '1 <a href="[test-shortcode-tag]"> 2 <a href="[test-shortcode-tag]" >',
+                                '1 <a href=""> 2 <a href="" >',
+                        ),
+                        array(
+                                '1 <a noise="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >',
+                                '1 <a noise="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >',
+                        ),
+                        array(
                                 '[gallery title="<div>hello</div>"]',
                                 '',