Changeset 33613

Timestamp:

08/13/2015 10:10:06 PM (10 years ago)

Author:

obenland

Message:

About: Third pass at 4.3 about page:

• Improves some of the feature descriptions.
• Uses .org CDN for images and feature video.
• Fixes an overzealous Jetpack style that adds unwanted padding.
• Uses more specific WP_List_Table header.
• Adds 4.3 tagline to freedoms and credit page.
• Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
• Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.

Location:

trunk/src/wp-admin

Files:

• about.php (modified) (5 diffs)
• credits.php (modified) (1 diff)
• css/about.css (modified) (3 diffs)
• freedoms.php (modified) (1 diff)

trunk/src/wp-admin/about.php

@@ -23 +23 @@
 include( ABSPATH . 'wp-admin/admin-header.php' );
 
+$video_url = 'https://videopress.com/embed/e9kH4FzP';
+$locale    = strtolower( str_replace( '_', '-', get_locale() ) );
+if ( 'en-us' !== $locale ) {
+    $video_url = add_query_arg( 'defaultLangCode', $locale, $video_url );
+}
+
 $major_features = array(
     array(
         'src'         => array(
-            'mp4'  => 'https://cldup.com/2k26HVNP6P.mp4',
-            'ogv'  => '',
-            'webm' => '',
+            'mp4'  => '//s.w.org/images/core/4.3/formatting.mp4',
+            'ogv'  => '//s.w.org/images/core/4.3/formatting.ogv',
+            'webm' => '//s.w.org/images/core/4.3/formatting.webm',
         ),
-        'heading'     => 'Formatting Shortcuts',
-
+        'heading'     => __( 'Formatting Shortcuts' ),
         /* Translators: 1: asterisks; 2: number sign; */
-        'description' => sprintf( 'Your writing flow just got faster with new formatting shortcuts in WordPress 4.3. Use asterisks to create lists and number signs to make a heading. No more breaking your flow; your text looks great with a %1$s and a %2$s.', '<code>*</code>', '<code>#</code>' ),
-    ),
-    array(
-        'src'         => 'https://cldup.com/k23oK-g_v1.jpg',
-        'heading'     => 'Menus in the Customizer',
-        'description' => 'Create your menu, update it, and preview it in the customizer, before sharing it with the world. With every release, it becomes easier and faster to build your site from the front-end. And a streamlined customizer design mean a mobile-first, accessibility ready interface.',
-    ),
-    array(
-        'src'         => 'https://cldup.com/t1HCztI0PR.jpg',
-        'heading'     => 'Better Passwords',
-        'description' => 'Keep your site more secure with WordPress’ improved approach to passwords. Instead of receiving passwords via email, you’ll get a password reset link. When you add new users to your site, WordPress will automatically generate a secure password.',
-    ),
-    array(
-        'src'         => 'https://cldup.com/8LxuMwmsvE.jpg',
-        'heading'     => 'Site Icons',
-        'description' => 'Site icons represent your site in browser tabs, bookmark menus, and on the home screen of mobile devices. Add your unique site icon in the customizer; it will even stay in place when you switch themes. Make your whole site reflect your brand.',
+        'description' => sprintf( __( 'Your writing flow just got faster with new formatting shortcuts in WordPress 4.3. Use asterisks to create lists and number signs to make a heading. No more breaking your flow; your text looks great with a %1$s and a %2$s.' ), '<code>*</code>', '<code>#</code>' ),
+    ),
+    array(
+        'src'         => '//s.w.org/images/core/4.3/menu-customizer.png',
+        'heading'     => __( 'Menus in the Customizer' ),
+        'description' => __( 'Create your menu, update it, and assign it, all while live-previewing in the customizer. The streamlined customizer design provides a mobile-friendly and accessible interface. With every release, it becomes easier and faster to make your site just the way you want it.' ),
+    ),
+    array(
+        'src'         => '//s.w.org/images/core/4.3/better-passwords.png',
+        'heading'     => __( 'Better Passwords' ),
+        'description' => __( 'Keep your site more secure with WordPress&#8217; improved approach to passwords. Instead of receiving passwords via email, you&#8217;ll get a password reset link. When you add new users to your site or edit a user profile, WordPress will automatically generate a secure password.' ),
+    ),
+    array(
+        'src'         => '//s.w.org/images/core/4.3/site-icon-customizer.png',
+        'heading'     => __( 'Site Icons' ),
+        'description' => __( 'Site icons represent your site in browser tabs, bookmark menus, and on the home screen of mobile devices. Add your unique site icon in the customizer; it will even stay in place when you switch themes. Make your whole site reflect your brand.' ),
     ),
 );
@@ -56 +61 @@
     array(
         'src'         => 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCA0MDAgNDAwIj48cGF0aCBmaWxsPSIjMDBhMGQyIiBkPSJNNTAgMjE1aDI0MHYzMEg1MHpNNTAgMjc1aDI0MHYzMEg1MHpNNTAgMTU1aDI0MHYzMEg1MHpNNTAgOTVoMjQwdjMwSDUwek0zMTAuMSA5NWwxOS45IDMwIDIwLjEtMzAiLz48L3N2Zz4=',
-        'heading'     => 'A smoother admin experience',
-        'description' => 'Refinements to the list view across the admin make your WordPress more accessible and easier to work with on any device.',
+        'heading'     => __( 'A smoother admin experience' ),
+        'description' => __( 'Refinements to the list view across the admin make your WordPress more accessible and easier to work with on any device.' ),
     ),
     array(
         'src'         => 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyMCAyMCI+PHBhdGggZmlsbD0iIzAwYTBkMiIgZD0iTTUgMmgxMHEuODIgMCAxLjQxLjU5VDE3IDR2OHEwIC44Mi0uNTkgMS40MVQxNSAxNGgtMmwtNSA1di01SDVxLS44MiAwLTEuNDEtLjU5VDMgMTJWNHEwLS44Mi41OS0xLjQxVDUgMnptOC41IDguNUwxMSA4bDIuNS0yLjUtMS0xTDEwIDcgNy41IDQuNWwtMSAxTDkgOGwtMi41IDIuNSAxIDFMMTAgOWwyLjUgMi41eiIvPjwvc3ZnPg==',
-        'heading'     => 'Comments turned off on pages',
-        'description' => 'All new pages that you create will have comments turned off. Keep discussions to your blog, right where they’re supposed to happen.',
+        'heading'     => __( 'Comments turned off on pages' ),
+        'description' => __( 'All new pages that you create will have comments turned off. Keep discussions to your blog, right where they&#8217;re supposed to happen.' ),
     ),
     array(
         'src'         => 'data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAzMiAzMiI+PHBhdGggZmlsbD0iIzAwYTBkMiIgZD0iTTI5LjMyOCA1LjcxMnEuMDQ4LS4xNDQuMDk2LS4zODR0LS4wNjQtLjgxNi0uNTI4LS45NzZxLS4zODQtLjM2OC0uODcyLS40NjR0LS43OTIgMGwtLjI4OC4wOHEtMS40NTYuNzItNS44OCAzLjczNnQtNi4zOTIgNS4xNzZxLS43MzYuODMyLTEuNDA4IDIuMzJ0LS44OCAzIC41NDQgMi4zOTJxLjgzMi43MzYgMi4zNDQuNTc2dDMuMDcyLS44MjQgMi4yNDgtMS4zNTJxMi4xNDQtMi4xNDQgNS4xNjgtNi42NTZ0My42MzItNS44MDh6TTIuMjQgMjguMjRxMS4wNTYtLjY4OCAxLjcxMi0xLjUyOHQuOTUyLTEuNjE2LjU0NC0xLjUyLjcyLTEuNDggMS4yNC0xLjI4cTEuMDg4LS44IDIuNTA0LS43MDR0Mi40MjQgMS4xNjhxLjgxNi44OC44MjQgMi42NHQtMS4wOCAyLjg5NnEtMS4yMTYgMS4xMi0yLjkwNCAxLjYyNHQtMy40MjQuNDI0LTMuNTEyLS42MjR6Ii8+PC9zdmc+',
-        'heading'     => 'Customize your site quickly' ,
-        'description' => 'Wherever you are on the front-end, you can click the customize button in the toolbar to swiftly make changes to your site.',
+        'heading'     => __( 'Customize your site quickly' ),
+        'description' => __( 'Wherever you are on the front-end, you can click the customize link in the toolbar to swiftly make changes to your site.' ),
     ),
 );
@@ -73 +78 @@
 $tech_features = array(
     array(
-        'heading'     => 'Taxonomy Roadmap',
-        'description' => 'Terms shared across multiple taxonomies are now split into separate terms.',
-    ),
-    array(
-        'heading'     => 'Template Hierarchy',
-
+        'heading'     => __( 'Taxonomy Roadmap' ),
+        'description' => __( 'Terms shared across multiple taxonomies are now split into separate terms.' ),
+    ),
+    array(
+        'heading'     => __( 'Template Hierarchy' ),
         /* Translators: 1: singular.php; 2: single.php; 3:page.php */
-        'description' => sprintf( 'Added %1$s as a fallback for %2$s and %3$s', '<code>singular.php</code>', '<code>single.php</code>', '<code>page.php</code>.' ),
-    ),
-    array(
-        'heading'     => 'List table',
-        'description' => 'List tables now can (and often should) have a primary column defined.',
+        'description' => sprintf( __( 'Added %1$s as a fallback for %2$s and %3$s' ), '<code>singular.php</code>', '<code>single.php</code>', '<code>page.php</code>.' ),
+    ),
+    array(
+        'heading'     => '<code>WP_List_Table</code>',
+        'description' => __( 'List tables can and should designate a primary column.' ),
     ),
 );
@@ -92 +96 @@
         <h1><?php printf( __( 'Welcome to WordPress&nbsp;%s' ), $display_version ); ?></h1>
 
-        <div class="about-text"><?php printf( 'Thank you for updating! WordPress %s: faster workflow, easier customization, strong by default.', $display_version ); ?></div>
+        <div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s makes it even easier to format your content and customize your site.' ), $display_version ); ?></div>
         <div class="wp-badge"><?php printf( __( 'Version %s' ), $display_version ); ?></div>
 
@@ -102 +106 @@
 
         <div class="headline-feature feature-video">
-            <!-- [4.3 video] -->
+            <iframe width="1050" height="591" src="<?php echo esc_url( $video_url ); ?>" frameborder="0" allowfullscreen></iframe>
+            <script src="https://videopress.com/videopress-iframe.js"></script>
         </div>
 

trunk/src/wp-admin/credits.php

@@ -81 +81 @@
 <h1><?php printf( __( 'Welcome to WordPress %s' ), $display_version ); ?></h1>
 
-<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s helps you communicate and share, globally.' ), $display_version ); ?></div>
+<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s makes it even easier to format your content and customize your site.' ), $display_version ); ?></div>
 
 <div class="wp-badge"><?php printf( __( 'Version %s' ), $display_version ); ?></div>

trunk/src/wp-admin/css/about.css

@@ -43 +43 @@
 }
 
+.about-wrap .jetpack-video-wrapper {
+    margin-bottom: 0;
+}
+
 /* WordPress Version Badge */
 
@@ -118 +122 @@
 .about-wrap ol li p {
     font-size: 14px;
+    font-weight: normal;
 }
 
@@ -208 +213 @@
     position: relative;
     margin: 40px 0;
-    /*padding-bottom: 56.25%; /* video is 1280 x 720 */
+    padding-bottom: 56.25%; /* video is 1280 x 720 */
     width: 100%;
     height: 0;

trunk/src/wp-admin/freedoms.php

@@ -20 +20 @@
 <h1><?php printf( __( 'Welcome to WordPress %s' ), $display_version ); ?></h1>
 
-<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s helps you communicate and share, globally.' ), $display_version ); ?></div>
+<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s makes it even easier to format your content and customize your site.' ), $display_version ); ?></div>
 
 <div class="wp-badge"><?php printf( __( 'Version %s' ), $display_version ); ?></div>