Changeset 33614

Timestamp:

08/13/2015 10:30:26 PM (11 years ago)

Author:

ocean90

Message:

Capabilities: Fall back to the edit_posts capability for orphaned comments.

Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-comments-list-table.php (modified) (3 diffs)
• src/wp-includes/capabilities.php (modified) (1 diff)
• tests/phpunit/tests/ajax/EditComment.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -473 +473 @@
                 }
 
-                $post = get_post();
-
                 $the_comment_status = wp_get_comment_status( $comment->comment_ID );
 
@@ -535 +533 @@
                         $format = '<a data-comment-id="%d" data-post-id="%d" data-action="%s" class="%s" title="%s" href="#">%s</a>';
 
-                        $actions['quickedit'] = sprintf( $format, $comment->comment_ID, $post->ID, 'edit', 'vim-q comment-inline',esc_attr__( 'Edit this item inline' ), __( 'Quick&nbsp;Edit' ) );
-
-                        $actions['reply'] = sprintf( $format, $comment->comment_ID, $post->ID, 'replyto', 'vim-r comment-inline', esc_attr__( 'Reply to this comment' ), __( 'Reply' ) );
+                        $actions['quickedit'] = sprintf( $format, $comment->comment_ID, $comment->comment_post_ID, 'edit', 'vim-q comment-inline',esc_attr__( 'Edit this item inline' ), __( 'Quick&nbsp;Edit' ) );
+
+                        $actions['reply'] = sprintf( $format, $comment->comment_ID, $comment->comment_post_ID, 'replyto', 'vim-r comment-inline', esc_attr__( 'Reply to this comment' ), __( 'Reply' ) );
                 }
 
@@ -673 +671 @@
                 $post = get_post();
 
+                if ( ! $post ) {
+                        return;
+                }
+
                 if ( isset( $this->pending_count[$post->ID] ) ) {
                         $pending_comments = $this->pending_count[$post->ID];

trunk/src/wp-includes/capabilities.php

@@ -1306 +1306 @@
                         break;
                 $post = get_post( $comment->comment_post_ID );
-                $caps = map_meta_cap( 'edit_post', $user_id, $post->ID );
+
+                /*
+                 * If the post doesn't exist, we have an orphaned comment.
+                 * Fall back to the edit_posts capability, instead.
+                 */
+                if ( $post ) {
+                        $caps = map_meta_cap( 'edit_post', $user_id, $post->ID );
+                } else {
+                        $caps = map_meta_cap( 'edit_posts', $user_id );
+                }
                 break;
         case 'unfiltered_upload':

trunk/tests/phpunit/tests/ajax/EditComment.php

@@ -47 +47 @@
                 ) );
                 $comment = array_pop( $comments );
+
+                // Set up a default request
+                $_POST['_ajax_nonce-replyto-comment'] = wp_create_nonce( 'replyto-comment' );
+                $_POST['comment_ID']                  = $comment->comment_ID;
+                $_POST['content']                     = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.';
+
+                // Make the request
+                try {
+                        $this->_handleAjax( 'edit-comment' );
+                } catch ( WPAjaxDieContinueException $e ) {
+                        unset( $e );
+                }
+
+                // Get the response
+                $xml = simplexml_load_string( $this->_last_response, 'SimpleXMLElement', LIBXML_NOCDATA );
+
+                // Check the meta data
+                $this->assertEquals( -1, (string) $xml->response[0]->edit_comment['position'] );
+                $this->assertEquals( $comment->comment_ID, (string) $xml->response[0]->edit_comment['id'] );
+                $this->assertEquals( 'edit-comment_' . $comment->comment_ID, (string) $xml->response['action'] );
+
+                // Check the payload
+                $this->assertNotEmpty( (string) $xml->response[0]->edit_comment[0]->response_data );
+
+                // And supplemental is empty
+                $this->assertEmpty( (string) $xml->response[0]->edit_comment[0]->supplemental );
+        }
+
+        /**
+         * @ticket 33154
+         */
+        function test_editor_can_edit_orphan_comments() {
+                global $wpdb;
+
+                // Become an editor
+                $this->_setRole( 'editor' );
+
+                // Get a comment
+                $comments = get_comments( array(
+                        'post_id' => $this->_comment_post->ID
+                ) );
+                $comment = array_pop( $comments );
+
+                // Manually update the comment_post_ID, because wp_update_comment() will prevent it.
+                $wpdb->query( "UPDATE {$wpdb->comments} SET comment_post_ID=0 WHERE comment_ID={$comment->comment_ID}" );
+                clean_comment_cache( $comment->comment_ID );
 
                 // Set up a default request