Changeset 33619

Timestamp:

08/15/2015 07:24:42 PM (9 years ago)

Author:

boonebgorges

Message:

Don't suspend cache invalidation when running term splitting batch routine.

wp_suspend_cache_invalidation() was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (3 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -4376 +4376 @@
          GROUP BY t.term_id
          HAVING term_tt_count > 1
-         LIMIT 20"
+         LIMIT 10"
     );
 
@@ -4402 +4402 @@
 
     // Split term data recording is slow, so we do it just once, outside the loop.
-    $suspend = wp_suspend_cache_invalidation( true );
     $split_term_data = get_option( '_split_terms', array() );
     $skipped_first_term = $taxonomies = array();
@@ -4433 +4432 @@
     }
 
-    wp_suspend_cache_invalidation( $suspend );
     update_option( '_split_terms', $split_term_data );