Changeset 33623

Timestamp:

08/17/2015 03:37:03 PM (10 years ago)

Author:

helen

Message:

List tables: Yet more primary column fallbacks.

Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (3 diffs)
• includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/css/list-tables.css

@@ -1765 +1765 @@
     }
 
-    .wp-list-table th:not(.column-primary),
-    .wp-list-table th:not(.column-primary),
-    .wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.column-primary):not(.check-column) {
+    .wp-list-table th.column-primary ~ th,
+    .wp-list-table tr:not(.inline-edit-row):not(.no-items) td.column-primary ~ td:not(.check-column) {
         display: none;
     }
@@ -1781 +1780 @@
     }
 
-    .wp-list-table .toggle-row {
+    .wp-list-table .column-primary .toggle-row {
         display: block;
     }
@@ -1796 +1795 @@
     }
 
-    .wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.column-primary):not(.check-column) {
+    .wp-list-table tr:not(.inline-edit-row):not(.no-items) td.column-primary ~ td:not(.check-column) {
         padding: 3px 8px 3px 35%;
     }

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1259 +1259 @@
      */
     protected function handle_row_actions( $item, $column_name, $primary ) {
-        return '';
+        return $column_name == $primary ? '<button type="button" class="toggle-row"><span class="screen-reader-text">' . __( 'Show more details' ) . '</span></button>' : '';
     }