Changeset 33625

Timestamp:

08/17/2015 06:45:33 PM (11 years ago)

Author:

obenland

Message:

Passwords: Use keyup event to prevent IE8's misinterpretation of propertychange.

Props adamsilverstein, peterwilsoncc.
Fixes #33385.

File:

• trunk/src/wp-admin/js/user-profile.js (modified) (5 diffs)

trunk/src/wp-admin/js/user-profile.js

@@ -48 +48 @@
                         .data( 'pw', $pass1.data( 'pw' ) )
                         .val( $pass1.val() )
-                        .on( 'input propertychange', function () {
+                        .on( 'keyup', function () {
                                 if ( $pass1Text.val() === currentPass ) {
                                         return;
@@ -63 +63 @@
                 }
 
-                $pass1.on( 'input propertychange pwupdate', function () {
+                $pass1.on( 'keyup pwupdate', function () {
                         if ( $pass1.val() === currentPass ) {
                                 return;
@@ -69 +69 @@
 
                         currentPass = $pass1.val();
-                        $pass1Text.val( currentPass );
+                        if ( $pass1Text.val() !== currentPass ) {
+                                $pass1Text.val( currentPass );
+                        }
                         $pass1.add( $pass1Text ).removeClass( 'short bad good strong' );
 
@@ -164 +166 @@
                  * pass2 field to the pass1 field, then running check_pass_strength.
                  */
-                $pass2 = $('#pass2').on( 'input propertychange', function () {
+                $pass2 = $('#pass2').on( 'keyup', function () {
                         if ( $pass2.val().length > 0 ) {
                                 $pass1.val( $pass2.val() );
@@ -245 +247 @@
                         select = $( '#display_name' );
 
-                $('#pass1').val('').on( 'input propertychange pwupdate', check_pass_strength );
+                $('#pass1').val('').on( 'keyup pwupdate', check_pass_strength );
                 $('#pass-strength-result').show();
                 $('.color-palette').click( function() {