Changeset 33652

Timestamp:

08/19/2015 07:32:04 PM (9 years ago)

Author:

boonebgorges

Message:

wp_update_term() should return a true integer for 'term_taxonomy_id'.

Props ipm-frommen.
Fixes #32876.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/term/wpUpdateTerm.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -3540 +3540 @@
     }
 
-    $tt_id = $wpdb->get_var( $wpdb->prepare( "SELECT tt.term_taxonomy_id FROM $wpdb->term_taxonomy AS tt INNER JOIN $wpdb->terms AS t ON tt.term_id = t.term_id WHERE tt.taxonomy = %s AND t.term_id = %d", $taxonomy, $term_id) );
+    $tt_id = (int) $wpdb->get_var( $wpdb->prepare( "SELECT tt.term_taxonomy_id FROM $wpdb->term_taxonomy AS tt INNER JOIN $wpdb->terms AS t ON tt.term_id = t.term_id WHERE tt.taxonomy = %s AND t.term_id = %d", $taxonomy, $term_id) );
 
     // Check whether this is a shared term that needs splitting.

trunk/tests/phpunit/tests/term/wpUpdateTerm.php

@@ -471 +471 @@
         $this->assertEquals( $term_by_id, $term_by_slug );
         $this->assertEquals( $term_by_id, $term_by_ttid );
+    }
+
+    /**
+     * @ticket 32876
+     */
+    public function test_wp_update_term_should_return_int_values_for_term_id_and_term_taxonomy_id() {
+        register_taxonomy( 'wptests_tax', 'post' );
+        $t = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+        ) );
+        $found = wp_update_term( $t, 'wptests_tax', array(
+            'slug' => 'foo',
+        ) );
+
+        $this->assertInternalType( 'int', $found['term_id'] );
+        $this->assertInternalType( 'int', $found['term_taxonomy_id'] );
     }