Changeset 33659

Timestamp:

08/20/2015 06:24:00 AM (9 years ago)

Author:

wonderboymusic

Message:

Deprecate post_permalink() (Introduced in 1.0, already had a deprecated argument in 1.3), which just wraps get_permalink() and was only used by XML-RPC in 4 places.

Props solarissmoke.
Fixes #16982.

Location:

trunk/src/wp-includes

Files:

• class-wp-xmlrpc-server.php (modified) (4 diffs)
• deprecated.php (modified) (1 diff)
• link-template.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -761 +761 @@
             'post_parent'       => strval( $post['post_parent'] ),
             'post_mime_type'    => $post['post_mime_type'],
-            'link'              => post_permalink( $post['ID'] ),
+            'link'              => get_permalink( $post['ID'] ),
             'guid'              => $post['guid'],
             'menu_order'        => intval( $post['menu_order'] ),
@@ -931 +931 @@
         // Get all of the page content and link.
         $full_page = get_extended( $page->post_content );
-        $link = post_permalink( $page->ID );
+        $link = get_permalink( $page->ID );
 
         // Get info the page parent if there is one.
@@ -5384 +5384 @@
 
             $post = get_extended($postdata['post_content']);
-            $link = post_permalink($postdata['ID']);
+            $link = get_permalink($postdata['ID']);
 
             // Get the author info.
@@ -5524 +5524 @@
 
             $post = get_extended($entry['post_content']);
-            $link = post_permalink($entry['ID']);
+            $link = get_permalink($entry['ID']);
 
             // Get the post author info.

trunk/src/wp-includes/deprecated.php

@@ -3637 +3637 @@
 }
 
+/**
+ * Retrieve permalink from post ID.
+ *
+ * @since 1.0.0
+ * @deprecated 4.4.0
+ *
+ * @param int|WP_Post $post_id Optional. Post ID or WP_Post object. Default is global $post.
+ * @return string|false
+ */
+function post_permalink( $post_id = 0 ) {
+    _deprecated_function( __FUNCTION__, '4.4', 'get_permalink()' );
+
+    return get_permalink( $post_id );
+}
+

trunk/src/wp-includes/link-template.php

@@ -287 +287 @@
      */
     return apply_filters( 'post_type_link', $post_link, $post, $leavename, $sample );
-}
-
-/**
- * Retrieve permalink from post ID.
- *
- * @since 1.0.0
- *
- * @param int|WP_Post $post_id    Optional. Post ID or WP_Post object. Default is global $post.
- * @param mixed       $deprecated Not used.
- * @return string|false
- */
-function post_permalink( $post_id = 0, $deprecated = '' ) {
-    if ( !empty( $deprecated ) )
-        _deprecated_argument( __FUNCTION__, '1.3' );
-
-    return get_permalink($post_id);
 }