Changeset 33697

Timestamp:

08/21/2015 06:12:56 PM (11 years ago)

Author:

wonderboymusic

Message:

In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead.

See #33491.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -1195 +1195 @@
                 // If the post is an autodraft, save the post as a draft and then attempt to save the meta.
                 if ( $post->post_status == 'auto-draft' ) {
-                        $save_POST = $_POST; // Backup $_POST
-                        $_POST = array(); // Make it empty for edit_post()
-                        $_POST['action'] = 'draft'; // Warning fix
-                        $_POST['post_ID'] = $pid;
-                        $_POST['post_type'] = $post->post_type;
-                        $_POST['post_status'] = 'draft';
+                        $post_data = array();
+                        $post_data['action'] = 'draft'; // Warning fix
+                        $post_data['post_ID'] = $pid;
+                        $post_data['post_type'] = $post->post_type;
+                        $post_data['post_status'] = 'draft';
                         $now = current_time('timestamp', 1);
-                        $_POST['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), date( get_option( 'date_format' ), $now ), date( get_option( 'time_format' ), $now ) );
-
-                        if ( $pid = edit_post() ) {
+                        $post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), date( get_option( 'date_format' ), $now ), date( get_option( 'time_format' ), $now ) );
+
+                        $pid = edit_post( $post_data );
+                        if ( $pid ) {
                                 if ( is_wp_error( $pid ) ) {
                                         $x = new WP_Ajax_Response( array(
@@ -1212 +1212 @@
                                         $x->send();
                                 }
-                                $_POST = $save_POST; // Now we can restore original $_POST again
+
                                 if ( !$mid = add_meta( $pid ) )
                                         wp_die( __( 'Please provide a custom field value.' ) );