Changeset 33711

Timestamp:

08/22/2015 07:42:30 PM (9 years ago)

Author:

boonebgorges

Message:

In wp_delete_term(), the $deleted_term object passed to filters should be generated before term relationships are deleted.

This allows the count property to reflect the pre-delete state of affairs,
rather than always being 0.

Props nicholas_io.
Fixes #33485.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/tests/term/wpDeleteTerm.php (added)

trunk/src/wp-includes/taxonomy.php

@@ -2552 +2552 @@
     }
 
+    // Get the term before deleting it or its term relationships so we can pass to actions below.
+    $deleted_term = get_term( $term, $taxonomy );
+
     $objects = $wpdb->get_col( $wpdb->prepare( "SELECT object_id FROM $wpdb->term_relationships WHERE term_taxonomy_id = %d", $tt_id ) );
 
@@ -2571 +2574 @@
     foreach ( $tax_object->object_type as $object_type )
         clean_object_term_cache( $objects, $object_type );
-
-    // Get the object before deletion so we can pass to actions below
-    $deleted_term = get_term( $term, $taxonomy );
 
     /**