Changeset 33767

Timestamp:

08/27/2015 02:08:31 AM (10 years ago)

Author:

boonebgorges

Message:

Rename param added to wp_list_categories() in [33764] to 'hide_title_if_empty'.

Props vilkatis, DrewAPicture.
Fixes #33565.

Location:

trunk

Files:

• src/wp-includes/category-template.php (modified) (4 diffs)
• tests/phpunit/tests/category/wpListCategories.php (modified) (4 diffs)

trunk/src/wp-includes/category-template.php

@@ -462 +462 @@
  *
  * @since 2.1.0
- * @since 4.4.0 Introduced the `hide_title_if_no_cats` argument.
+ * @since 4.4.0 Introduced the `hide_title_if_empty` argument.
  *
  * @param string|array $args {
@@ -494 +494 @@
  *     @type string       $title_li              Text to use for the list title `<li>` element. Pass an empty string
  *                                               to disable. Default 'Categories'.
- *     @type bool         $hide_title_if_no_cats Whether to hide the `$title_li` element if there are no terms in
+ *     @type bool         $hide_title_if_empty   Whether to hide the `$title_li` element if there are no terms in
  *                                               the list. Default false (title will always be shown).
  *     @type int          $depth                 Category depth. Used for tab indentation. Default 0.
@@ -512 +512 @@
         'exclude_tree' => '', 'current_category' => 0,
         'hierarchical' => true, 'title_li' => __( 'Categories' ),
-        'hide_title_if_no_cats' => false,
+        'hide_title_if_empty' => false,
         'echo' => 1, 'depth' => 0,
         'taxonomy' => 'category'
@@ -540 +540 @@
 
     $output = '';
-    if ( $r['title_li'] && 'list' == $r['style'] && ( ! empty( $categories ) || ! $r['hide_title_if_no_cats'] ) ) {
+    if ( $r['title_li'] && 'list' == $r['style'] && ( ! empty( $categories ) || ! $r['hide_title_if_empty'] ) ) {
         $output = '<li class="' . esc_attr( $r['class'] ) . '">' . $r['title_li'] . '<ul>';
     }

trunk/tests/phpunit/tests/category/wpListCategories.php

@@ -213 +213 @@
      * @ticket 33460
      */
-    public function test_hide_title_if_no_cats_should_be_respected_for_empty_lists_when_true() {
-        $found = wp_list_categories( array(
-            'echo' => false,
-            'hide_title_if_no_cats' => true,
+    public function test_hide_title_if_empty_should_be_respected_for_empty_lists_when_true() {
+        $found = wp_list_categories( array(
+            'echo' => false,
+            'hide_title_if_empty' => true,
         ) );
 
@@ -225 +225 @@
      * @ticket 33460
      */
-    public function test_hide_title_if_no_cats_should_be_respected_for_empty_lists_when_false() {
-        $found = wp_list_categories( array(
-            'echo' => false,
-            'hide_title_if_no_cats' => false,
+    public function test_hide_title_if_empty_should_be_respected_for_empty_lists_when_false() {
+        $found = wp_list_categories( array(
+            'echo' => false,
+            'hide_title_if_empty' => false,
         ) );
 
@@ -237 +237 @@
      * @ticket 33460
      */
-    public function test_hide_title_if_no_cats_should_be_ignored_when_category_list_is_not_empty() {
+    public function test_hide_title_if_empty_should_be_ignored_when_category_list_is_not_empty() {
         $cat = $this->factory->category->create();
 
@@ -243 +243 @@
             'echo' => false,
             'hide_empty' => false,
-            'hide_title_if_no_cats' => true,
+            'hide_title_if_empty' => true,
         ) );