Changeset 33773 for trunk/src/wp-admin/includes/post.php

Timestamp:

08/27/2015 08:56:54 PM (10 years ago)

Author:

johnbillion

Message:

Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post.

Fixes #32954
Props boonebgorges, johnbillion

File:

• trunk/src/wp-admin/includes/post.php (modified) (2 diffs)

trunk/src/wp-admin/includes/post.php

@@ -1309 +1309 @@
         $post_name_html = '<span id="editable-post-name" title="' . $title . '">' . $post_name_abridged . '</span>';
         $display_link = str_replace( array( '%pagename%', '%postname%' ), $post_name_html, urldecode( $permalink ) );
-        $pretty_permalink = str_replace( array( '%pagename%', '%postname%' ), $post_name, urldecode( $permalink ) );
 
         $return =  '<strong>' . __( 'Permalink:' ) . "</strong>\n";
@@ -1325 +1324 @@
             $return .= "<span id='view-post-btn'><a href='" . esc_url( $preview_link ) . "' class='button button-small' target='wp-preview-{$post->ID}'>$view_post</a></span>\n";
         } else {
-            if ( empty( $pretty_permalink ) ) {
-                $pretty_permalink = $permalink;
+            if ( 'publish' === $post->post_status ) {
+                // View Post button should always go to the saved permalink.
+                $pretty_permalink = get_permalink( $post );
+            } else {
+                // Allow non-published (private, future) to be viewed at a pretty permalink.
+                $pretty_permalink = str_replace( array( '%pagename%', '%postname%' ), $post->post_name, urldecode( $permalink ) );
             }