Changeset 33806 for trunk/src/wp-includes/comment-functions.php

Timestamp:

08/30/2015 02:18:18 AM (9 years ago)

Author:

wonderboymusic

Message:

get_comment_count() currently increments awaiting_moderation when comments are in the trash. This occurs because case 0: will match any value passed to switch that is a string that isn't specified in the list of cases. This is terrifying.

• Cases for 0 and 1 should be '1' and '0'
• Add unit tests for get_comment_count(). Currently, there are none.

See #33414.

File:

• trunk/src/wp-includes/comment-functions.php (modified) (1 diff)

trunk/src/wp-includes/comment-functions.php

@@ -376 +376 @@
                 $comment_count["total_comments"] += $row['total'];
                 break;
-            case 1:
+            case '1':
                 $comment_count['approved'] = $row['total'];
                 $comment_count['total_comments'] += $row['total'];
                 break;
-            case 0:
+            case '0':
                 $comment_count['awaiting_moderation'] = $row['total'];
                 $comment_count['total_comments'] += $row['total'];