Changeset 33820

Timestamp:

08/31/2015 03:50:05 AM (9 years ago)

Author:

SergeyBiryukov

Message:

Bump H3 headings to H2 on Themes screen for better accessibility.

props joehills.
fixes #33560.

Location:

trunk/src/wp-admin

Files:

• includes/theme.php (modified) (1 diff)
• js/theme.js (modified) (1 diff)
• themes.php (modified) (3 diffs)

trunk/src/wp-admin/includes/theme.php

@@ -534 +534 @@
                         <span class="current-label"><?php _e( 'Current Theme' ); ?></span>
                     <# } #>
-                    <h3 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h3>
-                    <h4 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h4>
+                    <h2 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h2>
+                    <h3 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h3>
                     <p class="theme-description">{{{ data.description }}}</p>
 

trunk/src/wp-admin/js/theme.js

@@ -984 +984 @@
         // 'Add new theme' element shown at the end of the grid
         if ( themes.data.settings.canInstall ) {
-            this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span></span></div><h3 class="theme-name">' + l10n.addNew + '</h3></a></div>' );
+            this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span></span></div><h2 class="theme-name">' + l10n.addNew + '</h2></a></div>' );
         }
 

trunk/src/wp-admin/themes.php

@@ -226 +226 @@
 
     <?php if ( $theme['active'] ) { ?>
-        <h3 class="theme-name" id="<?php echo $aria_name; ?>">
+        <h2 class="theme-name" id="<?php echo $aria_name; ?>">
             <?php
             /* translators: %s: theme name */
             printf( __( '<span>Active:</span> %s' ), $theme['name'] );
             ?>
-        </h3>
+        </h2>
     <?php } else { ?>
-        <h3 class="theme-name" id="<?php echo $aria_name; ?>"><?php echo $theme['name']; ?></h3>
+        <h2 class="theme-name" id="<?php echo $aria_name; ?>"><?php echo $theme['name']; ?></h2>
     <?php } ?>
 
@@ -328 +328 @@
 
     <# if ( data.active ) { #>
-        <h3 class="theme-name" id="{{ data.id }}-name">
+        <h2 class="theme-name" id="{{ data.id }}-name">
             <?php
             /* translators: %s: theme name */
             printf( __( '<span>Active:</span> %s' ), '{{{ data.name }}}' );
             ?>
-        </h3>
+        </h2>
     <# } else { #>
-        <h3 class="theme-name" id="{{ data.id }}-name">{{{ data.name }}}</h3>
+        <h2 class="theme-name" id="{{ data.id }}-name">{{{ data.name }}}</h2>
     <# } #>
 
@@ -377 +377 @@
                     <span class="current-label"><?php _e( 'Current Theme' ); ?></span>
                 <# } #>
-                <h3 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h3>
-                <h4 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h4>
+                <h2 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h2>
+                <h3 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h3>
 
                 <# if ( data.hasUpdate ) { #>