Changeset 33826

Timestamp:

08/31/2015 08:41:09 PM (10 years ago)

Author:

wonderboymusic

Message:

WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set.

See #11566.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -429 +429 @@
 
     /**
-     *
      * @global WP_Post $post
-     * @global object  $comment
-     *
-     * @param object $a_comment
-     */
-    public function single_row( $a_comment ) {
-        global $post, $comment;
-
-        $comment = $a_comment;
+     *
+     * @param object $comment
+     */
+    public function single_row( $comment ) {
+        global $post;
+
         $the_comment_class = wp_get_comment_status( $comment->comment_ID );
         if ( ! $the_comment_class ) {