Changeset 33853

Timestamp:

09/02/2015 04:20:46 PM (9 years ago)

Author:

SergeyBiryukov

Message:

Provide more helful feedback than just "Cheatin' uh?" for permission errors in wp-admin/media-upload.php.

props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.

File:

• trunk/src/wp-admin/media-upload.php (modified) (2 diffs)

trunk/src/wp-admin/media-upload.php

@@ -16 +16 @@
 require_once( dirname( __FILE__ ) . '/admin.php' );
 
-if (!current_user_can('upload_files'))
-    wp_die(__('You do not have permission to upload files.'));
+if ( ! current_user_can( 'upload_files' ) ) {
+    wp_die( __( 'You do not have permission to upload files.' ), 403 );
+}
 
 wp_enqueue_script('plupload-handlers');
@@ -32 +33 @@
 
 // Require an ID for the edit screen.
-if ( isset($action) && $action == 'edit' && !$ID ) {
-    wp_die( __( 'Cheatin’ uh?' ), 403 );
+if ( isset( $action ) && $action == 'edit' && !$ID ) {
+    wp_die(
+        '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
+        '<p>' . __( 'Invalid item ID.' ) . '</p>',
+        403
+    );
 }
 
 if ( ! empty( $_REQUEST['post_id'] ) && ! current_user_can( 'edit_post' , $_REQUEST['post_id'] ) ) {
-    wp_die( __( 'Cheatin&#8217; uh?' ), 403 );
+    wp_die(
+        '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
+        '<p>' . __( 'You are not allowed to edit this item.' ) . '</p>',
+        403
+    );
 }