Changeset 33854

Timestamp:

09/02/2015 04:28:18 PM (11 years ago)

Author:

SergeyBiryukov

Message:

Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/custom-header.php.

props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.

File:

• trunk/src/wp-admin/custom-header.php (modified) (2 diffs)

trunk/src/wp-admin/custom-header.php

@@ -684 +684 @@
         public function step_2() {
                 check_admin_referer('custom-header-upload', '_wpnonce-custom-header-upload');
-                if ( ! current_theme_supports( 'custom-header', 'uploads' ) )
-                        wp_die( __( 'Cheatin’ uh?' ), 403 );
+                if ( ! current_theme_supports( 'custom-header', 'uploads' ) ) {
+                        wp_die(
+                                '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
+                                '<p>' . __( 'The current theme does not support uploading a custom header image.' ) . '</p>',
+                                403
+                        );
+                }
 
                 if ( empty( $_POST ) && isset( $_GET['file'] ) ) {
@@ -835 +840 @@
                 check_admin_referer( 'custom-header-crop-image' );
 
-                if ( ! current_theme_supports( 'custom-header', 'uploads' ) )
-                        wp_die( __( 'Cheatin&#8217; uh?' ), 403 );
-
-                if ( ! empty( $_POST['skip-cropping'] ) && ! ( current_theme_supports( 'custom-header', 'flex-height' ) || current_theme_supports( 'custom-header', 'flex-width' ) ) )
-                        wp_die( __( 'Cheatin&#8217; uh?' ), 403 );
+                if ( ! current_theme_supports( 'custom-header', 'uploads' ) ) {
+                        wp_die(
+                                '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
+                                '<p>' . __( 'The current theme does not support uploading a custom header image.' ) . '</p>',
+                                403
+                        );
+                }
+
+                if ( ! empty( $_POST['skip-cropping'] ) && ! ( current_theme_supports( 'custom-header', 'flex-height' ) || current_theme_supports( 'custom-header', 'flex-width' ) ) ) {
+                        wp_die(
+                                '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
+                                '<p>' . __( 'The current theme does not support a flexible sized header image.' ) . '</p>',
+                                403
+                        );
+                }
 
                 if ( $_POST['oitar'] > 1 ) {