Changeset 33894

Timestamp:

09/03/2015 11:22:32 PM (10 years ago)

Author:

wonderboymusic

Message:

Handle more cases (untrailingslashit, HTTPS urls) for sanitizing an author URL for display in the comments list table.

Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -637 +637 @@
 
         $author_url = get_comment_author_url( $comment->comment_ID );
-        if ( 'http://' == $author_url ) {
-            $author_url = '';
-        }
-
-        $author_url_display = preg_replace( '|http://(www\.)?|i', '', $author_url );
+
+        $author_url_display = untrailingslashit( preg_replace( '|^http(s)?://(www\.)?|i', '', $author_url ) );
         if ( strlen( $author_url_display ) > 50 ) {
             $author_url_display = wp_html_excerpt( $author_url_display, 49, '…' );
         }
 
-
         echo "<strong>"; comment_author( $comment->comment_ID ); echo '</strong><br />';
-        if ( !empty( $author_url ) ) {
-            echo "<a title='$author_url' href='$author_url'>$author_url_display</a><br />";
+        if ( ! empty( $author_url_display ) ) {
+            printf( '<a href="%s">%s</a><br />', esc_url( $author_url ), esc_html( $author_url_display ) );
         }