Changeset 33903

Timestamp:

09/04/2015 09:16:11 PM (9 years ago)

Author:

boonebgorges

Message:

In get_terms(), allow terms to be ordered by 'term_id'.

[29128] introduced updated documentation for the 'orderby' parameter of
get_terms(). The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.

Location:

trunk

Files:

• src/wp-includes/taxonomy-functions.php (modified) (2 diffs)
• tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy-functions.php

@@ -946 +946 @@
  * @since 2.3.0
  * @since 4.2.0 Introduced 'name' and 'childless' parameters.
+ * @since 4.4.0 Introduced the ability to pass 'term_id' as an alias of 'id' for the `orderby` parameter.
  *
  * @global wpdb  $wpdb WordPress database abstraction object.
@@ -1133 +1134 @@
     } elseif ( 'none' == $_orderby ) {
         $orderby = '';
-    } elseif ( empty($_orderby) || 'id' == $_orderby ) {
+    } elseif ( empty( $_orderby ) || 'id' == $_orderby || 'term_id' === $_orderby ) {
         $orderby = 't.term_id';
     } else {

trunk/tests/phpunit/tests/term/getTerms.php

@@ -1187 +1187 @@
     }
 
+    /**
+     * @ticket 33726
+     */
+    public function test_orderby_term_id() {
+        register_taxonomy( 'wptests_tax', 'post' );
+        $t1 = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+            'name' => 'AAA',
+        ) );
+        $t2 = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+            'name' => 'ZZZ',
+        ) );
+        $t3 = $this->factory->term->create( array(
+            'taxonomy' => 'wptests_tax',
+            'name' => 'JJJ',
+        ) );
+
+        $found = get_terms( 'wptests_tax', array(
+            'orderby' => 'term_id',
+            'hide_empty' => false,
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEquals( array( $t1, $t2, $t3 ), $found );
+    }
+
     public function test_hierarchical_false_with_parent() {
         $initial_terms = $this->create_hierarchical_terms();