Changeset 33937

Timestamp:

09/07/2015 05:22:03 AM (9 years ago)

Author:

pento

Message:

Readme: Update the recommended PHP version to 5.6.

This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.

Location:

trunk

Files:

• src/readme.html (modified) (1 diff)
• tests/phpunit/tests/basic.php (modified) (1 diff)

trunk/src/readme.html

@@ -60 +60 @@
 <h2>Recommendations</h2>
 <ul>
-    <li><a href="http://php.net/">PHP</a> version <strong>5.4</strong> or higher.</li>
+    <li><a href="http://php.net/">PHP</a> version <strong>5.6</strong> or higher.</li>
     <li><a href="http://www.mysql.com/">MySQL</a> version <strong>5.5</strong> or higher.</li>
     <li>The <a href="http://httpd.apache.org/docs/2.2/mod/mod_rewrite.html">mod_rewrite</a> Apache module.</li>

trunk/tests/phpunit/tests/basic.php

@@ -27 +27 @@
         list( $version ) = explode( '-', $GLOBALS['wp_version'] );
         $this->assertEquals( $version, trim( $matches[1] ), "readme.html's version needs to be updated to $version." );
+
+        preg_match( '#Recommendations.*PHP</a> version <strong>([0-9.]*)#s', $readme, $matches );
+
+        $response = wp_remote_get( 'https://secure.php.net/supported-versions.php' );
+        if ( 200 != wp_remote_retrieve_response_code( $response ) ) {
+            $this->markTestSkipped( 'Could not contact PHP.net to check versions.' );
+        }
+        $php = wp_remote_retrieve_body( $response );
+
+        preg_match_all( '#<tr class="stable">\s*<td>\s*<a [^>]*>\s*([0-9.]*)#s', $php, $phpmatches );
+
+        $this->assertContains( $matches[1], $phpmatches[1] );
     }