Changeset 33949

Timestamp:

09/08/2015 07:03:17 PM (11 years ago)

Author:

boonebgorges

Message:

In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute.

As of [32484], wp_dropdown_categories() uses the $value_field value to
decide whether a given <option> should be 'selected'. However, $value_field
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (==) with the value of the 'selected'
parameter, which defaults to 0, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in <option> elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator ===.

Merges [33681] to the 4.3 branch.

Fixes #33452 for 4.3.1.

Location:

branches/4.3

Files:

• . (modified) (1 prop)
• src/wp-includes/category-template.php (modified) (1 diff)
• tests/phpunit/tests/category.php (modified) (1 diff)

branches/4.3/src/wp-includes/category-template.php

@@ -1208 +1208 @@
                 $output .= "\t<option class=\"level-$depth\" value=\"" . esc_attr( $category->{$value_field} ) . "\"";
 
-                if ( $category->{$value_field} == $args['selected'] )
+                // Type-juggling causes false matches, so we force everything to a string.
+                if ( (string) $category->{$value_field} === (string) $args['selected'] )
                         $output .= ' selected="selected"';
                 $output .= '>';

branches/4.3/tests/phpunit/tests/category.php

@@ -352 +352 @@
                 $this->assertContains( "value=\"test_category_2\" selected=\"selected\"", $found );
         }
+
+        /**
+         * @ticket 33452
+         */
+        public function test_wp_dropdown_categories_show_option_all_should_be_selected_if_no_selected_value_is_explicitly_passed_and_value_field_does_not_have_string_values() {
+                $cats = $this->factory->category->create_many( 3 );
+
+                $found = wp_dropdown_categories( array(
+                        'echo' => 0,
+                        'hide_empty' => 0,
+                        'show_option_all' => 'Foo',
+                        'value_field' => 'slug',
+                ) );
+
+                $this->assertContains( "value='0' selected='selected'", $found );
+
+                foreach ( $cats as $cat ) {
+                        $_cat = get_term( $cat, 'category' );
+                        $this->assertNotContains( 'value="' . $_cat->slug . '" selected="selected"', $found );
+                }
+        }
+
+        /**
+         * @ticket 33452
+         */
+        public function test_wp_dropdown_categories_show_option_all_should_be_selected_if_selected_value_of_0_string_is_explicitly_passed_and_value_field_does_not_have_string_values() {
+                $cats = $this->factory->category->create_many( 3 );
+
+                $found = wp_dropdown_categories( array(
+                        'echo' => 0,
+                        'hide_empty' => 0,
+                        'show_option_all' => 'Foo',
+                        'value_field' => 'slug',
+                        'selected' => '0',
+                ) );
+
+                $this->assertContains( "value='0' selected='selected'", $found );
+
+                foreach ( $cats as $cat ) {
+                        $_cat = get_term( $cat, 'category' );
+                        $this->assertNotContains( 'value="' . $_cat->slug . '" selected="selected"', $found );
+                }
+        }
 }