Changeset 33964 for trunk/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

09/09/2015 02:59:54 AM (9 years ago)

Author:

wonderboymusic

Message:

In WP_Comments_List_Table, favor passing WP_Comment instances instead of $comment_ID to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.

See #33638.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -443 +443 @@
         global $post;
 
-        $the_comment_class = wp_get_comment_status( $comment->comment_ID );
+        $the_comment_class = wp_get_comment_status( $comment );
         if ( ! $the_comment_class ) {
             $the_comment_class = '';
         }
-        $the_comment_class = join( ' ', get_comment_class( $the_comment_class, $comment->comment_ID, $comment->comment_post_ID ) );
+        $the_comment_class = join( ' ', get_comment_class( $the_comment_class, $comment, $comment->comment_post_ID ) );
 
         $post = get_post( $comment->comment_post_ID );
@@ -480 +480 @@
         }
 
-        $the_comment_status = wp_get_comment_status( $comment->comment_ID );
+        $the_comment_status = wp_get_comment_status( $comment );
 
         $out = '';
@@ -589 +589 @@
      */
     public function column_comment( $comment ) {
-        $comment_url = esc_url( get_comment_link( $comment->comment_ID ) );
+        $comment_url = esc_url( get_comment_link( $comment ) );
 
         echo '<div class="comment-author">';
@@ -599 +599 @@
         printf( __( 'Submitted on <a href="%1$s">%2$s at %3$s</a>' ), $comment_url,
             /* translators: comment date format. See http://php.net/date */
-            get_comment_date( __( 'Y/m/d' ), $comment->comment_ID ),
-            get_comment_date( get_option( 'time_format' ), $comment->comment_ID )
+            get_comment_date( __( 'Y/m/d' ), $comment ),
+            get_comment_date( get_option( 'time_format' ), $comment )
         );
 
         if ( $comment->comment_parent ) {
             $parent = get_comment( $comment->comment_parent );
-            $parent_link = esc_url( get_comment_link( $comment->comment_parent ) );
-            $name = get_comment_author( $parent->comment_ID );
+            $parent_link = esc_url( get_comment_link( $parent ) );
+            $name = get_comment_author( $parent );
             printf( ' | '.__( 'In reply to <a href="%1$s">%2$s</a>.' ), $parent_link, $name );
         }
 
         echo '</div>';
-        comment_text( $comment->comment_ID );
+        comment_text( $comment );
         if ( $this->user_can ) { ?>
         <div id="inline-<?php echo $comment->comment_ID; ?>" class="hidden">
@@ -636 +636 @@
         global $comment_status;
 
-        $author_url = get_comment_author_url( $comment->comment_ID );
+        $author_url = get_comment_author_url( $comment );
 
         $author_url_display = untrailingslashit( preg_replace( '|^http(s)?://(www\.)?|i', '', $author_url ) );
@@ -643 +643 @@
         }
 
-        echo "<strong>"; comment_author( $comment->comment_ID ); echo '</strong><br />';
+        echo "<strong>"; comment_author( $comment ); echo '</strong><br />';
         if ( ! empty( $author_url_display ) ) {
             printf( '<a href="%s">%s</a><br />', esc_url( $author_url ), esc_html( $author_url_display ) );
@@ -658 +658 @@
             }
 
-            $author_ip = get_comment_author_IP( $comment->comment_ID );
+            $author_ip = get_comment_author_IP( $comment );
             if ( $author_ip ) {
                 $author_ip_url = add_query_arg( array( 's' => $author_ip, 'mode' => 'detail' ), 'edit-comments.php' );
@@ -674 +674 @@
      */
     public function column_date( $comment ) {
-        return get_comment_date( __( 'Y/m/d \a\t g:i a' ), $comment->comment_ID );
+        return get_comment_date( __( 'Y/m/d \a\t g:i a' ), $comment );
     }