Changeset 34001

Timestamp:

09/10/2015 04:53:52 PM (9 years ago)

Author:

wonderboymusic

Message:

In get_page_uri(), do not add parent slugs to orphaned pages.

Adds unit test.

Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963.

Location:

trunk

Files:

• src/wp-includes/post-functions.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post-functions.php

@@ -4197 +4197 @@
 
     foreach ( $page->ancestors as $parent ) {
-        $uri = get_post( $parent )->post_name . '/' . $uri;
+        $parent = get_post( $parent );
+        if ( 'publish' === $parent->post_status ) {
+            $uri = $parent->post_name . '/' . $uri;
+        }
     }
 

trunk/tests/phpunit/tests/post.php

@@ -652 +652 @@
 
     /**
+     * @ticket 15963
+     */
+    function test_get_post_uri_check_orphan() {
+        $parent_id = $this->factory->post->create( array( 'post_name' => 'parent' ) );
+        $child_id = $this->factory->post->create( array( 'post_name' => 'child', 'post_parent' => $parent_id ) );
+
+        // check the parent for good measure
+        $this->assertEquals( 'parent', get_page_uri( $parent_id ) );
+
+        // try the child normally
+        $this->assertEquals( 'parent/child', get_page_uri( $child_id ) );
+
+        // now delete the parent and check
+        wp_delete_post( $parent_id );
+        $this->assertEquals( 'child', get_page_uri( $child_id ) );
+    }
+
+    /**
      * @ticket 23708
      */