Changeset 34015

Timestamp:

09/10/2015 08:50:12 PM (9 years ago)

Author:

wonderboymusic

Message:

Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin.

Props rachelbaker.
Fixes #33710.

Location:

trunk/src/wp-admin

Files:

• edit-form-comment.php (modified) (1 diff)
• includes/class-wp-comments-list-table.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-comment.php

@@ -120 +120 @@
 if ( $comment->comment_parent ) :
     $parent      = get_comment( $comment->comment_parent );
-    $parent_link = esc_url( get_comment_link( $comment->comment_parent ) );
-    $name        = get_comment_author( $parent->comment_ID );
-?>
-<div class="misc-pub-section misc-pub-reply-to">
-    <?php printf(
-        /* translators: comment link */
-        __( 'In reply to: %s' ),
-        '<b><a href="' . $parent_link . '">' . $name . '</a></b>'
-    ); ?>
-</div>
-<?php endif; ?>
+    if ( $parent ) :
+        $parent_link = esc_url( get_comment_link( $comment->comment_parent ) );
+        $name        = get_comment_author( $parent->comment_ID );
+    ?>
+    <div class="misc-pub-section misc-pub-reply-to">
+        <?php printf(
+            /* translators: comment link */
+            __( 'In reply to: %s' ),
+            '<b><a href="' . $parent_link . '">' . $name . '</a></b>'
+        ); ?>
+    </div>
+<?php endif;
+endif; ?>
 
 <?php

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -608 +608 @@
         if ( $comment->comment_parent ) {
             $parent = get_comment( $comment->comment_parent );
-            $parent_link = esc_url( get_comment_link( $parent ) );
-            $name = get_comment_author( $parent );
-            printf( ' | '.__( 'In reply to <a href="%1$s">%2$s</a>.' ), $parent_link, $name );
+            if ( $parent ) {
+                $parent_link = esc_url( get_comment_link( $parent ) );
+                $name = get_comment_author( $parent );
+                printf( ' | '.__( 'In reply to <a href="%1$s">%2$s</a>.' ), $parent_link, $name );
+            }
         }