WordPress.org

Make WordPress Core


Ignore:
Timestamp:
09/11/2015 01:25:21 AM (6 years ago)
Author:
pento
Message:

Schema: Increase the length of wp_options.option_name.

It's pretty easy to run over the option_name length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from VARCHAR(64) to VARCHAR(191) significantly reduces the risk of this occurring.

Because option_name has a UNIQUE index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/schema.php

    r33774 r34030  
    136136CREATE TABLE $wpdb->options (
    137137  option_id bigint(20) unsigned NOT NULL auto_increment,
    138   option_name varchar(64) NOT NULL default '',
     138  option_name varchar(191) NOT NULL default '',
    139139  option_value longtext NOT NULL,
    140140  autoload varchar(20) NOT NULL default 'yes',
Note: See TracChangeset for help on using the changeset viewer.