Changeset 34030 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

09/11/2015 01:25:21 AM (9 years ago)

Author:

pento

Message:

Schema: Increase the length of wp_options.option_name.

It's pretty easy to run over the option_name length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from VARCHAR(64) to VARCHAR(191) significantly reduces the risk of this occurring.

Because option_name has a UNIQUE index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (2 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -538 +538 @@
     if ( $wp_current_db_version < 33056 )
         upgrade_431();
+
+    if ( $wp_current_db_version < 34030 )
+        upgrade_440();
 
     maybe_disable_link_manager();
@@ -1597 +1600 @@
 
 /**
+ * Executes changes made in WordPress 4.4.0.
+ *
+ * @since 4.4.0
+ *
+ * @global int  $wp_current_db_version Current version.
+ * @global wpdb $wpdb                  WordPress database abstraction object.
+ */
+function upgrade_440() {
+    global $wp_current_db_version, $wpdb;
+
+    if ( $wp_current_db_version < 34030 ) {
+        $wpdb->query( "ALTER TABLE {$wpdb->options} MODIFY option_name VARCHAR(191)" );
+    }
+}
+
+/**
  * Executes network-level upgrade routines.
  *