Changeset 34078 for branches/4.3

Timestamp:

09/12/2015 12:29:54 PM (10 years ago)

Author:

ocean90

Message:

Passwords: Refresh password fields when content is pasted into fields.

Use feature detection to determine whether password inputs should use the keyup or input event.

Merge of [34060] to the 4.3 branch.

Props peterwilsoncc, adamsilverstein.
Fixes #33398.

File:

• branches/4.3/src/wp-admin/js/user-profile.js (modified) (5 diffs)

branches/4.3/src/wp-admin/js/user-profile.js

@@ -8 +8 @@
         $pass1Text,
         $pass1Label,
-
         $pass2,
-
         $weakRow,
         $weakCheckbox,
-
         $toggleButton,
         $submitButtons,
         $submitButton,
-        currentPass;
+        currentPass,
+        inputEvent;
+
+    /*
+     * Use feature detection to determine whether password inputs should use
+     * the `keyup` or `input` event. Input is preferred but lacks support
+     * in legacy browsers.
+     */
+    if ( 'oninput' in document.createElement( 'input' ) ) {
+        inputEvent = 'input';
+    } else {
+        inputEvent = 'keyup';
+    }
 
     function generatePassword() {
@@ -49 +58 @@
             .data( 'pw', $pass1.data( 'pw' ) )
             .val( $pass1.val() )
-            .on( 'keyup', function () {
+            .on( inputEvent, function () {
                 if ( $pass1Text.val() === currentPass ) {
                     return;
@@ -64 +73 @@
         }
 
-        $pass1.on( 'keyup pwupdate', function () {
+        $pass1.on( inputEvent + ' pwupdate', function () {
             if ( $pass1.val() === currentPass ) {
                 return;
@@ -173 +182 @@
          * pass2 field to the pass1 field, then running check_pass_strength.
          */
-        $pass2 = $('#pass2').on( 'keyup', function () {
+        $pass2 = $('#pass2').on( inputEvent, function () {
             if ( $pass2.val().length > 0 ) {
                 $pass1.val( $pass2.val() );
@@ -258 +267 @@
             select = $( '#display_name' );
 
-        $('#pass1').val('').on( 'keyup pwupdate', check_pass_strength );
+        $('#pass1').val('').on( inputEvent + ' pwupdate', check_pass_strength );
         $('#pass-strength-result').show();
         $('.color-palette').click( function() {