Changeset 34085

Timestamp:

09/12/2015 06:53:56 PM (9 years ago)

Author:

wonderboymusic

Message:

In wp_insert_post(), when setting $post_author, use isset() instead of ! empty() to allow 0 to be passed as the value for $post_author.

Adds unit tests.

Props ericdaams, wonderboymusic.
Fixes #32585.

Location:

trunk

Files:

• src/wp-includes/post-functions.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post-functions.php

@@ -3043 +3043 @@
     // These variables are needed by compact() later.
     $post_content_filtered = $postarr['post_content_filtered'];
-    $post_author = empty( $postarr['post_author'] ) ? $user_id : $postarr['post_author'];
+    $post_author = isset( $postarr['post_author'] ) ? $postarr['post_author'] : $user_id;
     $ping_status = empty( $postarr['ping_status'] ) ? get_default_comment_status( $post_type, 'pingback' ) : $postarr['ping_status'];
     $to_ping = isset( $postarr['to_ping'] ) ? sanitize_trackback_urls( $postarr['to_ping'] ) : '';

trunk/tests/phpunit/tests/post.php

@@ -1201 +1201 @@
         wp_set_current_user( $old_uid );
     }
+
+    /**
+     * @ticket 32585
+     */
+    public function test_wp_insert_post_author_zero() {
+        $post_id = $this->factory->post->create( array( 'post_author' => 0 ) );
+
+        $this->assertEquals( 0, get_post( $post_id )->post_author );
+    }
+
+    /**
+     * @ticket 32585
+     */
+    public function test_wp_insert_post_author_null() {
+        $post_id = $this->factory->post->create( array( 'post_author' => null ) );
+
+        $this->assertEquals( $this->author_id, get_post( $post_id )->post_author );
+    }
 }