Changeset 34116 for trunk/src/wp-admin/network/user-new.php

Timestamp:

09/14/2015 12:42:34 PM (10 years ago)

Author:

ocean90

Message:

Passwords: Deprecate second parameter of wp_new_user_notification().

The second parameter $plaintext_pass was removed in [33023] and restored as $notify in [33620] with a different behavior. If you have a plugin overriding wp_new_user_notification() which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)

File:

• trunk/src/wp-admin/network/user-new.php (modified) (1 diff)

trunk/src/wp-admin/network/user-new.php

@@ -52 +52 @@
             $add_user_errors = new WP_Error( 'add_user_fail', __( 'Cannot add user.' ) );
         } else {
-            wp_new_user_notification( $user_id, 'both' );
+            wp_new_user_notification( $user_id, null, 'both' );
             wp_redirect( add_query_arg( array('update' => 'added'), 'user-new.php' ) );
             exit;