Changeset 34177

Timestamp:

09/15/2015 10:26:22 AM (11 years ago)

Author:

johnbillion

Message:

Remove the ability to view the post listing screen and post editing screen for post types with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.

If your plugin or site does rely on this behaviour, the arguments that are passed to register_post_type() should be altered so that show_ui is true, and arguments such as show_in_menu, show_in_nav_menus, and show_in_admin_bar are false.

Fixes #33763
Props swissspidy, johnbillion

Location:

trunk/src

Files:

• wp-admin/edit.php (modified) (1 diff)
• wp-admin/post.php (modified) (1 diff)
• wp-includes/link-template.php (modified) (1 diff)

trunk/src/wp-admin/edit.php

@@ -12 +12 @@
 if ( ! $typenow )
         wp_die( __( 'Invalid post type' ) );
+
+if ( ! in_array( $typenow, get_post_types( array( 'show_ui' => true ) ) ) ) {
+        wp_die( __( 'You are not allowed to edit posts in this post type.' ) );
+}
 
 if ( 'attachment' === $typenow ) {

trunk/src/wp-admin/post.php

@@ -110 +110 @@
                 wp_die( __( 'Unknown post type.' ) );
 
+        if ( ! in_array( $typenow, get_post_types( array( 'show_ui' => true ) ) ) ) {
+                wp_die( __( 'You are not allowed to edit posts in this post type.' ) );
+        }
+
         if ( ! current_user_can( 'edit_post', $post_id ) )
                 wp_die( __( 'You are not allowed to edit this item.' ) );

trunk/src/wp-includes/link-template.php

@@ -1229 +1229 @@
                 return;
 
+        if ( ! in_array( $post->post_type, get_post_types( array( 'show_ui' => true ) ) ) ) {
+                return;
+        }
+
         /**
          * Filter the post edit link.