Changeset 34215 for trunk/src/wp-includes/post-functions.php

Timestamp:

09/15/2015 06:53:12 PM (10 years ago)

Author:

wonderboymusic

Message:

In WP::parse_request(), don't add query vars of non-viewable post types to WP::public_query_vars. In register_post_type(), don't add query vars of non-viewable post types to WP::public_query_vars.
In _unregister_post_type() (unit tests), don't add query vars of non-viewable post types to WP::public_query_vars.

Adds unit test.

Fixes #30018.

File:

• trunk/src/wp-includes/post-functions.php (modified) (1 diff)

trunk/src/wp-includes/post-functions.php

@@ -1073 +1073 @@
     }
 
-    if ( false !== $args->query_var && ! empty( $wp ) ) {
+    if ( false !== $args->query_var ) {
         if ( true === $args->query_var )
             $args->query_var = $post_type;
         else
             $args->query_var = sanitize_title_with_dashes( $args->query_var );
-        $wp->add_query_var( $args->query_var );
+
+        if ( $wp && is_post_type_viewable( $args ) ) {
+            $wp->add_query_var( $args->query_var );
+        }
     }