Changeset 34270 for trunk/src/wp-includes/comment-functions.php

Timestamp:

09/17/2015 08:00:31 PM (10 years ago)

Author:

boonebgorges

Message:

Lazy-load comment meta on single post pages.

[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
get_comment_meta() is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.

File:

• trunk/src/wp-includes/comment-functions.php (modified) (1 diff)

trunk/src/wp-includes/comment-functions.php

@@ -2377 +2377 @@
 }
 
+/**
+ * Lazy load comment meta when inside of a `WP_Query` loop.
+ *
+ * @since 4.4.0
+ *
+ * @param null $check      The `$check` param passed from the 'pre_comment_metadata' hook.
+ * @param int  $comment_id ID of the comment whose metadata is being cached.
+ * @return null In order not to short-circuit `get_metadata()`.
+ */
+function wp_lazyload_comment_meta( $check, $comment_id ) {
+    global $wp_query;
+
+    if ( ! empty( $wp_query->comments ) ) {
+        // Don't use `wp_list_pluck()` to avoid by-reference manipulation.
+        $comment_ids = array();
+        foreach ( $wp_query->comments as $comment ) {
+            $comment_ids[] = $comment->comment_ID;
+        }
+        update_meta_cache( 'comment', $comment_ids );
+    }
+
+    return $check;
+}
+
 //
 // Internal