Changeset 34325

Timestamp:

09/19/2015 04:40:34 PM (9 years ago)

Author:

wonderboymusic

Message:

Admin: when toggling select/deselect "all" via JS - :visible needs to be bound to not toggle disabled inputs.

Props tywayne.
Fixes #32309.

File:

• trunk/src/wp-admin/js/common.js (modified) (3 diffs)

trunk/src/wp-admin/js/common.js

@@ -410 +410 @@
         if ( e.shiftKey ) {
             if ( !lastClicked ) { return true; }
-            checks = $( lastClicked ).closest( 'form' ).find( ':checkbox' );
+            checks = $( lastClicked ).closest( 'form' ).find( ':checkbox' ).filter( ':visible:enabled' );
             first = checks.index( lastClicked );
             last = checks.index( this );
@@ -427 +427 @@
 
         // toggle "check all" checkboxes
-        var unchecked = $(this).closest('tbody').find(':checkbox').filter(':visible').not(':checked');
+        var unchecked = $(this).closest('tbody').find(':checkbox').filter(':visible:enabled').not(':checked');
         $(this).closest('table').children('thead, tfoot').find(':checkbox').prop('checked', function() {
             return ( 0 === unchecked.length );
@@ -444 +444 @@
             .children().children('.check-column').find(':checkbox')
             .prop('checked', function() {
-                if ( $(this).is(':hidden') ) {
+                if ( $(this).is(':hidden,:disabled') ) {
                     return false;
                 }