Changeset 34347

Timestamp:

09/20/2015 03:25:45 AM (9 years ago)

Author:

wonderboymusic

Message:

The 'get_sample_permalink_html' filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with 'get_sample_permalink' filter added in [34309].

Props SergeyBiryukov.
Fixes #33927.

File:

• trunk/src/wp-admin/includes/post.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -1351 +1351 @@
      *
      * @since 2.9.0
-     *
-     * @param string      $return    Sample permalink HTML markup.
-     * @param int|WP_Post $id        Post object or ID.
-     * @param string      $new_title New sample permalink title.
-     * @param string      $new_slug  New sample permalink slug.
+     * @since 4.4.0 Added `$post` parameter.
+     *
+     * @param string  $return    Sample permalink HTML markup.
+     * @param int     $post_id   Post ID.
+     * @param string  $new_title New sample permalink title.
+     * @param string  $new_slug  New sample permalink slug.
+     * @param WP_Post $post      Post object.
      */
-    $return = apply_filters( 'get_sample_permalink_html', $return, $id, $new_title, $new_slug );
+    $return = apply_filters( 'get_sample_permalink_html', $return, $post->ID, $new_title, $new_slug, $post );
 
     return $return;