Changeset 34383 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

09/22/2015 06:05:39 AM (10 years ago)

Author:

wonderboymusic

Message:

List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.

Props wonderboymusic, Viper007Bond.
Fixes #21249.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (10 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -284 +284 @@
      */
     public function get_pagination_arg( $key ) {
-        if ( 'page' == $key )
+        if ( 'page' === $key ) {
             return $this->get_pagenum();
-
-        if ( isset( $this->_pagination_args[$key] ) )
+        }
+
+        if ( isset( $this->_pagination_args[$key] ) ) {
             return $this->_pagination_args[$key];
+        }
     }
 
@@ -441 +443 @@
 
         foreach ( $this->_actions as $name => $title ) {
-            $class = 'edit' == $name ? ' class="hide-if-no-js"' : '';
+            $class = 'edit' === $name ? ' class="hide-if-no-js"' : '';
 
             echo "\t<option value='$name'$class>$title</option>\n";
@@ -599 +601 @@
             foreach ( $this->modes as $mode => $title ) {
                 $classes = array( 'view-' . $mode );
-                if ( $current_mode == $mode )
+                if ( $current_mode === $mode )
                     $classes[] = 'current';
                 printf(
@@ -783 +785 @@
         }
 
-        if ( 'bottom' == $which ) {
+        if ( 'bottom' === $which ) {
             $html_current_page  = $current;
             $total_pages_before = '<span class="screen-reader-text">' . __( 'Current Page' ) . '</span><span id="table-paging" class="paging-input">';
@@ -1026 +1028 @@
             $current_orderby = '';
 
-        if ( isset( $_GET['order'] ) && 'desc' == $_GET['order'] )
+        if ( isset( $_GET['order'] ) && 'desc' === $_GET['order'] )
             $current_order = 'desc';
         else
@@ -1045 +1047 @@
             }
 
-            if ( 'cb' == $column_key )
+            if ( 'cb' === $column_key )
                 $class[] = 'check-column';
             elseif ( in_array( $column_key, array( 'posts', 'comments', 'links' ) ) )
@@ -1057 +1059 @@
                 list( $orderby, $desc_first ) = $sortable[$column_key];
 
-                if ( $current_orderby == $orderby ) {
-                    $order = 'asc' == $current_order ? 'desc' : 'asc';
+                if ( $current_orderby === $orderby ) {
+                    $order = 'asc' === $current_order ? 'desc' : 'asc';
                     $class[] = 'sorted';
                     $class[] = $current_order;
@@ -1137 +1139 @@
      */
     protected function display_tablenav( $which ) {
-        if ( 'top' == $which )
+        if ( 'top' === $which ) {
             wp_nonce_field( 'bulk-' . $this->_args['plural'] );
-
+        }
         if ( $this->has_items() ) : ?>
     <div class="tablenav <?php echo esc_attr( $which ); ?>">
@@ -1248 +1250 @@
             $attributes = "class='$classes' $data";
 
-            if ( 'cb' == $column_name ) {
+            if ( 'cb' === $column_name ) {
                 echo '<th scope="row" class="check-column">';
                 echo $this->column_cb( $item );
@@ -1286 +1288 @@
      */
     protected function handle_row_actions( $item, $column_name, $primary ) {
-        return $column_name == $primary ? '<button type="button" class="toggle-row"><span class="screen-reader-text">' . __( 'Show more details' ) . '</span></button>' : '';
+        return $column_name === $primary ? '<button type="button" class="toggle-row"><span class="screen-reader-text">' . __( 'Show more details' ) . '</span></button>' : '';
     }