Make WordPress Core


Ignore:
Timestamp:
09/22/2015 06:05:39 AM (9 years ago)
Author:
wonderboymusic
Message:

List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.

Props wonderboymusic, Viper007Bond.
Fixes #21249.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

    r34289 r34383  
    123123
    124124        $order_by = isset( $_REQUEST['orderby'] ) ? $_REQUEST['orderby'] : '';
    125         if ( $order_by == 'registered' ) {
     125        if ( $order_by === 'registered' ) {
    126126            $query .= ' ORDER BY registered ';
    127         } elseif ( $order_by == 'lastupdated' ) {
     127        } elseif ( $order_by === 'lastupdated' ) {
    128128            $query .= ' ORDER BY last_updated ';
    129         } elseif ( $order_by == 'blogname' ) {
     129        } elseif ( $order_by === 'blogname' ) {
    130130            if ( is_subdomain_install() ) {
    131131                $query .= ' ORDER BY domain ';
     
    133133                $query .= ' ORDER BY path ';
    134134            }
    135         } elseif ( $order_by == 'blog_id' ) {
     135        } elseif ( $order_by === 'blog_id' ) {
    136136            $query .= ' ORDER BY blog_id ';
    137137        } else {
     
    140140
    141141        if ( isset( $order_by ) ) {
    142             $order = ( isset( $_REQUEST['order'] ) && 'DESC' == strtoupper( $_REQUEST['order'] ) ) ? "DESC" : "ASC";
     142            $order = ( isset( $_REQUEST['order'] ) && 'DESC' === strtoupper( $_REQUEST['order'] ) ) ? "DESC" : "ASC";
    143143            $query .= $order;
    144144        }
     
    191191        parent::pagination( $which );
    192192
    193         if ( 'top' == $which )
     193        if ( 'top' === $which )
    194194            $this->view_switcher( $mode );
    195195    }
     
    321321        global $mode;
    322322
    323         if ( 'list' == $mode ) {
     323        if ( 'list' === $mode ) {
    324324            $date = __( 'Y/m/d' );
    325325        } else {
     
    327327        }
    328328
    329         echo ( $blog['last_updated'] == '0000-00-00 00:00:00' ) ? __( 'Never' ) : mysql2date( $date, $blog['last_updated'] );
     329        echo ( $blog['last_updated'] === '0000-00-00 00:00:00' ) ? __( 'Never' ) : mysql2date( $date, $blog['last_updated'] );
    330330    }
    331331
     
    341341        global $mode;
    342342
    343         if ( 'list' == $mode ) {
     343        if ( 'list' === $mode ) {
    344344            $date = __( 'Y/m/d' );
    345345        } else {
     
    347347        }
    348348
    349         if ( $blog['registered'] == '0000-00-00 00:00:00' ) {
     349        if ( $blog['registered'] === '0000-00-00 00:00:00' ) {
    350350            echo '—';
    351351        } else {
Note: See TracChangeset for help on using the changeset viewer.