Changeset 34383 for trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

Timestamp:

09/22/2015 06:05:39 AM (11 years ago)

Author:

wonderboymusic

Message:

List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.

Props wonderboymusic, Viper007Bond.
Fixes #21249.

File:

• trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -258 +258 @@
                         return 0;
 
-                if ( 'DESC' == $order ) {
+                if ( 'DESC' === $order ) {
                         return strcasecmp( $b, $a );
                 } else {
@@ -338 +338 @@
                         }
 
-                        if ( 'search' != $type ) {
+                        if ( 'search' !== $type ) {
                                 $status_links[$type] = sprintf( "<a href='%s' %s>%s</a>",
                                         add_query_arg('plugin_status', $type, 'plugins.php'),
-                                        ( $type == $status ) ? ' class="current"' : '',
+                                        ( $type === $status ) ? ' class="current"' : '',
                                         sprintf( $text, number_format_i18n( $count ) )
                                         );
@@ -401 +401 @@
                 echo '<div class="alignleft actions">';
 
-                if ( ! $this->screen->in_admin( 'network' ) && 'recently_activated' == $status )
+                if ( ! $this->screen->in_admin( 'network' ) && 'recently_activated' === $status ) {
                         submit_button( __( 'Clear List' ), 'button', 'clear-recent-list', false );
-                elseif ( 'top' == $which && 'mustuse' == $status )
+                } elseif ( 'top' === $which && 'mustuse' === $status ) {
                         echo '<p>' . sprintf( __( 'Files in the <code>%s</code> directory are executed automatically.' ), str_replace( ABSPATH, '/', WPMU_PLUGIN_DIR ) ) . '</p>';
-                elseif ( 'top' == $which && 'dropins' == $status )
+                } elseif ( 'top' === $which && 'dropins' === $status ) {
                         echo '<p>' . sprintf( __( 'Drop-ins are advanced plugins in the <code>%s</code> directory that replace WordPress functionality when present.' ), str_replace( ABSPATH, '', WP_CONTENT_DIR ) ) . '</p>';
-
+                }
                 echo '</div>';
         }
@@ -459 +459 @@
                 );
 
-                if ( 'mustuse' == $context ) {
+                if ( 'mustuse' === $context ) {
                         $is_active = true;
-                } elseif ( 'dropins' == $context ) {
+                } elseif ( 'dropins' === $context ) {
                         $dropins = _get_dropins();
                         $plugin_name = $plugin_file;