Changeset 34460 for trunk/tests/phpunit/tests/admin/includesComment.php

Timestamp:

09/23/2015 06:15:39 PM (9 years ago)

Author:

boonebgorges

Message:

Allow comment_exists() to match based on GMT date.

The comment_date_gmt field of the wp_comments table is indexed, which makes
WHERE matches against the field much faster than against the unindexed
comment_date. For bulk operations like data import, the speed difference can
be meaningful.

We continue to default to 'blog' for $timezone, to preserve compatibility
with existing uses.

Props apokalyptik.
Fixes #33871.

File:

• trunk/tests/phpunit/tests/admin/includesComment.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/includesComment.php

@@ -24 +24 @@
         $this->assertEquals( $p1, comment_exists( 1, '2014-05-06 12:00:00' ) );
     }
+
+    /**
+     * @ticket 33871
+     */
+    public function test_default_value_of_timezone_should_be_blog() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array(
+            'comment_author' => 1,
+            'comment_post_ID' => $p,
+            'comment_date' => '2014-05-06 12:00:00',
+            'comment_date_gmt' => '2014-05-06 07:00:00',
+        ) );
+
+        $this->assertEquals( $p, comment_exists( 1, '2014-05-06 12:00:00' ) );
+    }
+
+    /**
+     * @ticket 33871
+     */
+    public function test_should_respect_timezone_blog() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array(
+            'comment_author' => 1,
+            'comment_post_ID' => $p,
+            'comment_date' => '2014-05-06 12:00:00',
+            'comment_date_gmt' => '2014-05-06 07:00:00',
+        ) );
+
+        $this->assertEquals( $p, comment_exists( 1, '2014-05-06 12:00:00', 'blog' ) );
+    }
+
+    /**
+     * @ticket 33871
+     */
+    public function test_should_respect_timezone_gmt() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array(
+            'comment_author' => 1,
+            'comment_post_ID' => $p,
+            'comment_date' => '2014-05-06 12:00:00',
+            'comment_date_gmt' => '2014-05-06 07:00:00',
+        ) );
+
+        $this->assertEquals( $p, comment_exists( 1, '2014-05-06 07:00:00', 'gmt' ) );
+    }
+
+    /**
+     * @ticket 33871
+     */
+    public function test_invalid_timezone_should_fall_back_on_blog() {
+        $p = $this->factory->post->create();
+        $c = $this->factory->comment->create( array(
+            'comment_author' => 1,
+            'comment_post_ID' => $p,
+            'comment_date' => '2014-05-06 12:00:00',
+            'comment_date_gmt' => '2014-05-06 07:00:00',
+        ) );
+
+        $this->assertEquals( $p, comment_exists( 1, '2014-05-06 12:00:00', 'not_a_valid_value' ) );
+    }
 }