Changeset 34464 for trunk/src/wp-includes/widgets/class-wp-widget-recent-posts.php

Timestamp:

09/24/2015 12:16:16 AM (11 years ago)

Author:

wonderboymusic

Message:

Recent Posts Widget: remove HTML fragment caching. The cache currently doesn't work cross-scheme and causes mixed content issues for links. The widget was written pre-$split_the_query, after which post objects can be served from the cache.

Fixes #27565.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-recent-posts.php (modified) (4 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-recent-posts.php

@@ -21 +21 @@
                 parent::__construct('recent-posts', __('Recent Posts'), $widget_ops);
                 $this->alt_option_name = 'widget_recent_entries';
-
-                add_action( 'save_post', array($this, 'flush_widget_cache') );
-                add_action( 'deleted_post', array($this, 'flush_widget_cache') );
-                add_action( 'switch_theme', array($this, 'flush_widget_cache') );
         }
 
@@ -32 +28 @@
          */
         public function widget( $args, $instance ) {
-                $cache = array();
-                if ( ! $this->is_preview() ) {
-                        $cache = wp_cache_get( 'widget_recent_posts', 'widget' );
-                }
-
-                if ( ! is_array( $cache ) ) {
-                        $cache = array();
-                }
-
                 if ( ! isset( $args['widget_id'] ) ) {
                         $args['widget_id'] = $this->id;
                 }
-
-                if ( isset( $cache[ $args['widget_id'] ] ) ) {
-                        echo $cache[ $args['widget_id'] ];
-                        return;
-                }
-
-                ob_start();
 
                 $title = ( ! empty( $instance['title'] ) ) ? $instance['title'] : __( 'Recent Posts' );
@@ -100 +80 @@
 
                 endif;
-
-                if ( ! $this->is_preview() ) {
-                        $cache[ $args['widget_id'] ] = ob_get_flush();
-                        wp_cache_set( 'widget_recent_posts', $cache, 'widget' );
-                } else {
-                        ob_end_flush();
-                }
         }
 
@@ -119 +92 @@
                 $instance['number'] = (int) $new_instance['number'];
                 $instance['show_date'] = isset( $new_instance['show_date'] ) ? (bool) $new_instance['show_date'] : false;
-                $this->flush_widget_cache();
-
-                $alloptions = wp_cache_get( 'alloptions', 'options' );
-                if ( isset($alloptions['widget_recent_entries']) )
-                        delete_option('widget_recent_entries');
-
                 return $instance;
-        }
-
-        /**
-         * @access public
-         */
-        public function flush_widget_cache() {
-                wp_cache_delete('widget_recent_posts', 'widget');
         }