Changeset 34466

Timestamp:

09/24/2015 12:48:23 AM (9 years ago)

Author:

wonderboymusic

Message:

Users: in WP_User::__unset(), don't reset the deprecated prop id to ID. Still throw the deprecated notice.

Update unit test.

Fixes #20043.

Location:

trunk

Files:

• src/wp-includes/class-wp-user.php (modified) (1 diff)
• tests/phpunit/tests/user.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-user.php

@@ -346 +346 @@
         if ( 'id' == $key ) {
             _deprecated_argument( 'WP_User->id', '2.1', __( 'Use <code>WP_User->ID</code> instead.' ) );
-            $key = 'ID';
         }
 

trunk/tests/phpunit/tests/user.php

@@ -200 +200 @@
         $this->assertNotEmpty( $user->ID );
         unset( $user->ID );
-        $this->assertEmpty( $user->ID );
+        $this->assertNotEmpty( $user->ID );
     }