Changeset 34467

Timestamp:

09/24/2015 01:06:17 AM (9 years ago)

Author:

wonderboymusic

Message:

List Tables: add JS code to dynamically toggle the disabled attribute of the Bulk Actions dropdown and Apply button.

Props wonderboymusic, pareshradadiya.
Fixes #31634.

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-list-table.php (modified) (1 diff)
• wp-admin/includes/update-core.php (modified) (1 diff)
• wp-admin/js/list-table.js (added)
• wp-includes/script-loader.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -438 +438 @@
             return;
 
-        echo "<label for='bulk-action-selector-" . esc_attr( $which ) . "' class='screen-reader-text'>" . __( 'Select bulk action' ) . "</label>";
-        echo "<select name='action$two' id='bulk-action-selector-" . esc_attr( $which ) . "'>\n";
-        echo "<option value='-1' selected='selected'>" . __( 'Bulk Actions' ) . "</option>\n";
+        echo '<label for="bulk-action-selector-' . esc_attr( $which ) . '" class="screen-reader-text">' . __( 'Select bulk action' ) . '</label>';
+        echo '<select name="action' . $two . '" id="bulk-action-selector-' . esc_attr( $which ) . "\">\n";
+        echo '<option value="-1">' . __( 'Bulk Actions' ) . "</option>\n";
 
         foreach ( $this->_actions as $name => $title ) {
             $class = 'edit' === $name ? ' class="hide-if-no-js"' : '';
 
-            echo "\t<option value='$name'$class>$title</option>\n";
+            echo "\t" . '<option value="' . $name . '"' . $class . '>' . $title . "</option>\n";
         }
 

trunk/src/wp-admin/includes/update-core.php

@@ -280 +280 @@
 'wp-admin/images/star.gif',
 'wp-admin/js/list-table.dev.js',
-'wp-admin/js/list-table.js',
+//'wp-admin/js/list-table.js', // restored in 4.4
 'wp-includes/default-embeds.php',
 'wp-includes/js/tinymce/plugins/wordpress/img/help.gif',

trunk/src/wp-includes/script-loader.php

@@ -78 +78 @@
     ) );
 
-    $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array('jquery', 'hoverIntent', 'utils'), false, 1 );
+    $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array('jquery', 'hoverIntent', 'utils', 'list-table'), false, 1 );
     did_action( 'init' ) && $scripts->localize( 'common', 'commonL10n', array(
         'warnDelete' => __( "You are about to permanently delete the selected items.\n  'Cancel' to stop, 'OK' to delete." ),
@@ -397 +397 @@
     $scripts->add( 'user-suggest', "/wp-admin/js/user-suggest$suffix.js", array( 'jquery-ui-autocomplete' ), false, 1 );
 
+    $scripts->add( 'list-table', "/wp-admin/js/list-table$suffix.js", array( 'jquery' ), false, 1 );
+
     $scripts->add( 'admin-bar', "/wp-includes/js/admin-bar$suffix.js", array(), false, 1 );