Changeset 34492 for trunk/src/wp-includes/canonical.php

Timestamp:

09/24/2015 02:03:05 PM (9 years ago)

Author:

wonderboymusic

Message:

Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.

Awesome rewrite bug: the page query var was being set to '/4' in $wp. When cast to int, it returns 0 (Bless you, PHP). WP_Query calls trim( $page, '/' ) when setting its own query var. The few places that were checking page before posts were queried now have sanity checks, so that these changes work without flushing rewrites.

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.

File:

• trunk/src/wp-includes/canonical.php (modified) (2 diffs)

trunk/src/wp-includes/canonical.php

@@ -147 +147 @@
                 $redirect['query'] = _remove_qs_args_if_not_in_url( $redirect['query'], array( 'page', 'feed', 'p', 'page_id', 'attachment_id', 'pagename', 'name', 'post_type' ), $redirect_url );
             }
+        }
+
+        if ( get_query_var( 'page' ) && $wp_query->post &&
+            false !== strpos( $wp_query->post->post_content, '<!--nextpage-->' ) ) {
+            $redirect['path'] = rtrim( $redirect['path'], (int) get_query_var( 'page' ) . '/' );
+            $redirect['query'] = remove_query_arg( 'page', $redirect['query'] );
+            $redirect_url = get_permalink( $wp_query->post->ID );
         }
 
@@ -561 +568 @@
         if ( get_query_var( 'feed' ) )
             return get_post_comments_feed_link( $post_id, get_query_var( 'feed' ) );
-        elseif ( get_query_var( 'page' ) )
+        elseif ( get_query_var( 'page' ) && 1 < get_query_var( 'page' ) )
             return trailingslashit( get_permalink( $post_id ) ) . user_trailingslashit( get_query_var( 'page' ), 'single_paged' );
         else