Changeset 34492 for trunk/src/wp-includes/class-wp-rewrite.php

Timestamp:

09/24/2015 02:03:05 PM (9 years ago)

Author:

wonderboymusic

Message:

Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.

Awesome rewrite bug: the page query var was being set to '/4' in $wp. When cast to int, it returns 0 (Bless you, PHP). WP_Query calls trim( $page, '/' ) when setting its own query var. The few places that were checking page before posts were queried now have sanity checks, so that these changes work without flushing rewrites.

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.

File:

• trunk/src/wp-includes/class-wp-rewrite.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-rewrite.php

@@ -1072 +1072 @@
                     $sub2 .= '?$';
 
-                    //post pagination, e.g. <permalink>/2/
-                    $match = $match . '(/[0-9]+)?/?$';
+                    // Post pagination, e.g. <permalink>/2/
+                    // Previously: '(/[0-9]+)?/?$', which produced '/2' for page.
+                    // When cast to int, returned 0.
+                    $match = $match . '(?:/([0-9]+))?/?$';
                     $query = $index . '?' . $query . '&page=' . $this->preg_index($num_toks + 1);
                 } else { //not matching a permalink so this is a lot simpler