Changeset 34492 for trunk/src/wp-includes/class-wp.php

Timestamp:

09/24/2015 02:03:05 PM (9 years ago)

Author:

wonderboymusic

Message:

Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.

Awesome rewrite bug: the page query var was being set to '/4' in $wp. When cast to int, it returns 0 (Bless you, PHP). WP_Query calls trim( $page, '/' ) when setting its own query var. The few places that were checking page before posts were queried now have sanity checks, so that these changes work without flushing rewrites.

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.

File:

• trunk/src/wp-includes/class-wp.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp.php

@@ -588 +588 @@
      */
     public function handle_404() {
-        global $wp_query;
+        global $wp_query, $wp;
 
         // If we've already issued a 404, bail.
@@ -597 +597 @@
         if ( is_admin() || is_robots() || $wp_query->posts ) {
 
-            // Only set X-Pingback for single posts.
+            $success = true;
             if ( is_singular() ) {
                 $p = clone $wp_query->post;
+                // Only set X-Pingback for single posts that allow pings.
                 if ( $p && pings_open( $p ) ) {
                     @header( 'X-Pingback: ' . get_bloginfo( 'pingback_url' ) );
                 }
-            }
-
-            status_header( 200 );
-            return;
+
+                // check for paged content that exceeds the max number of pages
+                $next = '<!--nextpage-->';
+                if ( $p && false !== strpos( $p->post_content, $next ) && ! empty( $wp->query_vars['page'] ) ) {
+                    $page = trim( $wp->query_vars['page'], '/' );
+                    $success = (int) $page <= ( substr_count( $p->post_content, $next ) + 1 );
+                }
+            }
+
+            if ( $success ) {
+                status_header( 200 );
+                return;
+            }
         }